Skip to content

Commit 7242fc8

Browse files
committed
INT-4574: JDBC: Add NOT NULL for primary keys (#2698)
* INT-4574: JDBC: Add NOT NULL for primary keys JIRA: https://jira.spring.io/browse/INT-4574 Some RDBMS don't allow have nullable columns for primary keys * Add NOT NULL for all the columns involved in primary keys **Cherry-pick to 4.3.x** * * Include index generation into the `schema.sql.vpp` * * Remove redundant blank line from generated scripts * * Fix INT_CHANNEL_MESSAGE primary generation # Conflicts: # spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-mysql.sql # spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-oracle.sql # spring-integration-jdbc/src/main/sql/schema.sql.vpp
1 parent 07655ee commit 7242fc8

File tree

11 files changed

+99
-99
lines changed

11 files changed

+99
-99
lines changed

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-db2.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE TIMESTAMP NOT NULL,
77
MESSAGE_BYTES BLOB,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
);
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
);
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE TIMESTAMP NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-derby.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE TIMESTAMP NOT NULL,
77
MESSAGE_BYTES BLOB,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
);
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
);
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE TIMESTAMP NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-h2.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE TIMESTAMP NOT NULL,
77
MESSAGE_BYTES LONGVARBINARY,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
);
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
);
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE TIMESTAMP NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-hsqldb.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE TIMESTAMP NOT NULL,
77
MESSAGE_BYTES LONGVARBINARY,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
);
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
);
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE TIMESTAMP NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-mysql-5_6_4.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE DATETIME(6) NOT NULL,
77
MESSAGE_BYTES BLOB,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
) ENGINE=InnoDB;
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
) ENGINE=InnoDB;
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE DATETIME(6) NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-mysql.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE DATETIME NOT NULL,
77
MESSAGE_BYTES BLOB,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
) ENGINE=InnoDB;
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
) ENGINE=InnoDB;
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE DATETIME NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-oracle10g.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR2(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR2(100) NOT NULL,
66
CREATED_DATE TIMESTAMP NOT NULL,
77
MESSAGE_BYTES BLOB,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR2(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR2(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
);
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR2(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR2(100) NOT NULL,
2323
MARKED NUMBER(19,0),
2424
COMPLETE NUMBER(19,0),
2525
LAST_RELEASED_SEQUENCE NUMBER(19,0),
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
);
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR2(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR2(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE TIMESTAMP NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-postgresql.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE TIMESTAMP NOT NULL,
77
MESSAGE_BYTES BYTEA,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
);
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
);
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE TIMESTAMP NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-sqlserver.sql

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
-- Autogenerated: do not edit this file
22

33
CREATE TABLE INT_MESSAGE (
4-
MESSAGE_ID CHAR(36),
5-
REGION VARCHAR(100),
4+
MESSAGE_ID CHAR(36) NOT NULL,
5+
REGION VARCHAR(100) NOT NULL,
66
CREATED_DATE DATETIME NOT NULL,
77
MESSAGE_BYTES IMAGE,
88
constraint MESSAGE_PK primary key (MESSAGE_ID, REGION)
@@ -11,15 +11,15 @@ CREATE TABLE INT_MESSAGE (
1111
CREATE INDEX INT_MESSAGE_IX1 ON INT_MESSAGE (CREATED_DATE);
1212

1313
CREATE TABLE INT_GROUP_TO_MESSAGE (
14-
GROUP_KEY CHAR(36),
15-
MESSAGE_ID CHAR(36),
16-
REGION VARCHAR(100),
14+
GROUP_KEY CHAR(36) NOT NULL,
15+
MESSAGE_ID CHAR(36) NOT NULL,
16+
REGION VARCHAR(100) NOT NULL,
1717
constraint GROUP_TO_MESSAGE_PK primary key (GROUP_KEY, MESSAGE_ID, REGION)
1818
);
1919

2020
CREATE TABLE INT_MESSAGE_GROUP (
21-
GROUP_KEY CHAR(36),
22-
REGION VARCHAR(100),
21+
GROUP_KEY CHAR(36) NOT NULL,
22+
REGION VARCHAR(100) NOT NULL,
2323
MARKED BIGINT,
2424
COMPLETE BIGINT,
2525
LAST_RELEASED_SEQUENCE BIGINT,
@@ -29,8 +29,8 @@ CREATE TABLE INT_MESSAGE_GROUP (
2929
);
3030

3131
CREATE TABLE INT_LOCK (
32-
LOCK_KEY CHAR(36),
33-
REGION VARCHAR(100),
32+
LOCK_KEY CHAR(36) NOT NULL,
33+
REGION VARCHAR(100) NOT NULL,
3434
CLIENT_ID CHAR(36),
3535
CREATED_DATE DATETIME NOT NULL,
3636
constraint LOCK_PK primary key (LOCK_KEY, REGION)

0 commit comments

Comments
 (0)