Skip to content

Fix Checkstyle configuration for nullability annotations #35205

@sbrannen

Description

@sbrannen

Overview

While assessing #35195, I noticed that there are a few issues with our Checkstyle configuration regarding nullability annotations.

  • ^(?!org\.jspecify|\.annotations).*(NonNull|Nullable)$ contains a |.
  • ^(?!org\.jspecify|\.annotations).*(NonNull|Nullable)$ matches against NonNull but not against Nonnull, and therefore incorrectly permits usage of javax.annotation.Nonnull.
  • Some of the Checkstyle suppressions no longer apply.

Related Issues

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions