Remove redundant value from illegalClasses for IllegalImportCheck
#35195
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See spring-projectsgh-35114 Signed-off-by: Johnny Lim <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mengnankkkk
approved these changes
Jul 13, 2025
sbrannen
changed the title
illegalClasses for IllegalImportCheck
sbrannen
added a commit
that referenced
this pull request
Jul 15, 2025
While assessing #35195, I noticed the following issues with our Checkstyle configuration regarding nullability annotations. - "^(?!org\.jspecify|\.annotations).*(NonNull|Nullable)$" contains a "|". - "^(?!org\.jspecify|\.annotations).*(NonNull|Nullable)$" matches against NonNull but not against Nonnull, and therefore incorrectly permits usage of javax.annotation.Nonnull. - Some of the Checkstyle suppressions no longer apply. This commit addresses all of the above issues and updates several tests to use example annotations other than javax.annotation.Nonnull where feasible. See gh-35195 Closes gh-35205
|
Well spotted, @izeye. 👍 However, since that change was introduced in conjunction with #35114, which is assigned to 7.0 M7, which has not yet been released, I simply decided to revert that particular commit (see aac61b8). In light of that, I am closing this PR. In addition, I noticed other issues with our Checkstyle rules which I addressed in 4fdf40e. Cheers, Sam |
sbrannen
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes redundant value from
illegalClassesforIllegalImportCheckas it seems to be covered by^(?!org\.jspecify|\.annotations).*(NonNull|Nullable)already.Related Issues