Skip to content

Add final modifier to fields of RunIdIncrementer and Job/Step BuilderFactory APIs #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
*
* @author Dave Syer
* @author Mahmoud Ben Hassine
*
* @author Jinho Han
*/
public class JobBuilderFactory {

private JobRepository jobRepository;
private final JobRepository jobRepository;

/**
* @param jobRepository The {@link JobRepository} to be used by the builder factory.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@
*
* @author Dave Syer
* @author Mahmoud Ben Hassine
*
* @author Jinho Han
*/
public class StepBuilderFactory {

private JobRepository jobRepository;
private final JobRepository jobRepository;

private PlatformTransactionManager transactionManager;
private final PlatformTransactionManager transactionManager;

/**
* Constructor for the {@link StepBuilderFactory}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@
*
* @author Dave Syer
* @author Mahmoud Ben Hassine
* @author Jinho Han
*/
public class RunIdIncrementer implements JobParametersIncrementer {

private static String RUN_ID_KEY = "run.id";
private static final String RUN_ID_KEY = "run.id";

private String key = RUN_ID_KEY;

Expand Down