Add final modifier to fields of RunIdIncrementer and Job/Step BuilderFactory APIs #4143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,11 +24,11 @@ | |||
| * | |||
| * @author Dave Syer | |||
| * @author Mahmoud Ben Hassine | |||
| * | |||
| * @author brick0123 | |||
There was a problem hiding this comment.
Please use your real name here and in git commits, see https://github.com/spring-projects/spring-batch/blob/main/CONTRIBUTING.md#use-your-real-name-in-git-commits. Thank you upfront.
There was a problem hiding this comment.
I modified it. thank you
fmbenhassine
added
pr-for: enhancement
status: waiting-for-reporter
fmbenhassine
removed
the
status: waiting-for-reporter
fmbenhassine
pushed a commit
that referenced
this pull request
Feb 16, 2023
|
Rebased and merged as fa70bcd. Thank you for your contribution! |
fmbenhassine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these fields are not reassigned, added final.
JobBuilderFactory,StepBuilderFactoryandRunIdIncrementer