Skip to content

Conversation

samaaron
Copy link
Collaborator

No description provided.

himanshu007-creator and others added 30 commits November 12, 2021 18:48
Fix output of output of the 'onset lambdas' example
Improve with_arg_bpm_scaling example
Spider - Breaking change - Fix current_debug so it reports the same value as use_debug
It is expected that there are not translations available for all languages, so it is not an error if one isn't found.

Fixes: #3171
Currently translated at 67.0% (244 of 364 strings)
Currently translated at 67.5% (246 of 364 strings)
Currently translated at 31.3% (114 of 364 strings)
Currently translated at 81.0% (1639 of 2023 strings)
Currently translated at 1.6% (33 of 2023 strings)
When moving the scheduling of the 24 distinct MIDI clock ticks to the BEAM, I forgot to account for the duration arg which lets you define how many Sonic Pi beats you want the MIDI beat ticks to be spread over. Also a bunch of scheduling logic remained which has now been removed.
MIDI clock beats are a bit stuttery on my RPi sending MIDI to an external synth via USB.

I'm not sure what the cause of this is - it could be issues with jitter in the USB comms or Erlang scheduler jitter.

This patch tries an alternative scheduling approach - instead of spawning 24 processes - one for each MIDI clock tick, we spawn just 1 process which iterates and sends each of the 24 ticks before terminating. It shouldn't make any difference but it's worth a try.
Currently translated at 25.2% (92 of 364 strings)
We now wait for a few similarly spread out taps before we start to calculate the BPM which is now rounded to the nearest integer.
Previously the stylesheet was read from disk and re-calculated every time it was requested. It is now cached by default and a re-calculation can be explicitly requested with reloadStylesheet(). getAppStylesheet() now simply returns the cached version (or generates it and then returns it if the cache is empty).
Hitting the tap tempo shortcut now flashes the Tap button as if it was clicked. Also, when the BPM changes, or the tap tempo logic resets, these are also indicated by colour changes.
This wasn't correctly linked.
Previously the button border was the same as the background and hence invisible. This patch fixes this to make the borders visible.
maintainence -> maintenance
Fix typo in CONTRIBUTORS.md
Introduce a new GUI slider and corresponding scrubber for shifting the phase of all triggered events - synths, MIDI & OSC.

Also additional improvements to the Link Metronome UI.
Method names were accidentally swapped.
Thanks so much to everyone that has contributed to Sonic Pi in any way xx
Fix handling of scsynth_opts from audio-settings.toml
Previously we were supplying the -I flag with 0 to scsynth on macOS. This was in an attempt to not bind to the audio inputs by default. However, with certain external sound cards, it appears that this also blocks output (perhaps they're duplex?).

We still set -i to 0 to specify no input channels, but no longer set the -I flag.

This only affects macOS.
Thanks to everyone that has ever contributed in any way x
This means we can fetch both concurrently and also introduce a timeout in case the server is not reachable.

Not being able to check for the latest version and message shouldn't stop the system from booting :-)
On some systems QCursor::setPos() doesn't appear to work which impacted the drag behaviour of the new scrubber widgets.

This patch assumes that setPos() is a null op and fixes this behaviour.

On systems where setPos() is working correctly, the mouse will still be reset to its original position when the dragging started. Otherwise, the final cursor position will move as dictated by the dragging.
It appears that on some platforms QCursor::setPos(pos); is asynchronous and therefore calling QCursor::pos(); immediately after may not return the position just moved to.

We now detect whether setPos is functional on the current system at initialisation and then deviate our behaviour depending on this knowledge.

This stuff seems very fiddly to get to behave similarly across platforms!
…/MIDI

The function was accidentally set as private and therefore not being called correctly. This patch fixes this.
@samaaron samaaron merged commit 78f0a98 into stable Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants