Fix handling of scsynth_opts from audio-settings.toml #3196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `scsynth_opts` and `scynth_opts_override` were being discarded as `unify_toml_opts_hash` maps options to scsynth command args through `OPTS_TOML_KEY_CONVERSION`, which doesn't contain such keys.
|
Brilliant work, thanks so much for both figuring out the issue and for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was trying to change the "max logins" scsynth option through the
scsynth_optsfrom audio-settings.toml and after some attempts I noticed changing this option andscsynth_opts_overridehad no effect.After some investigation I discovered it's caused by a bug in
daemon.rb. Bothscsynth_optsandscynth_opts_overridewere being discarded asunify_toml_opts_hashmaps options to scsynth command args throughOPTS_TOML_KEY_CONVERSION, which doesn't contain such keys.The fix involves simply passing the original TOML options hash down to
merge_optsso it can correctly extract thescsynth_*opts.