fix(iOS): fix detents not changing if sheetInitialDetent > 0 #2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kligarski
commented
May 22, 2025
I think the main culprit here is this block: react-native-screens/ios/RNSScreen.mm Lines 1334 to 1340 in c188d35 This gets called everytime you drag, causing performance issues. hence the jumpy glitch. Moving it to I've added this fix to my PR #2902 since it caused an issue with the translation value I wanted to add. Also, we wanted to actually use |
lodev09
added a commit
to lodev09/react-native-screens
that referenced
this pull request
May 23, 2025
…e detent index update
2 tasks
kligarski
added a commit
that referenced
this pull request
Jun 2, 2025
…eProps (#2952) ## Description Previously, `updateFormSheetPresentationStyle` was called from `finalizeUpdates` every time it was called, which would run many times when the sheet was being dragged. This impacted performance and was the cause of the bug which was fixed in #2935 by introducing a flag for setting initial detent. Now, we are checking `updateMask` in `finalizeUpdates` method. If the props have changed, we call `updateFormSheetPresentationStyle`. We don't need the flag anymore so I removed it as well. Thanks to @lodev09 for [reporting the problem and suggesting possible solution](#2935 (comment)). ## Changes - remove `_sheetHasInitialDetentSet` - check if props have changed using `updateMask` before calling `updateFormSheetPresentationStyle` ## Test code and steps to reproduce Run formSheet-related test screens in the example app, such as `Test2543`, `TestFormSheet` (you can change `sheetInitialDetent` in the file and save to see the update), `Test2877`. ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing detents on iOS form sheets would not work correctly if
sheetInitialDetentwas set to value other than0. For some reason, initial detent was set on every update instead of being set only once.Fixes #2543.
Changes
_hasInitialDetentSetflag and use it to determine whether to set initial detentTest2543test screen and e2e testScreenshots / GIFs
2543_before.mp4
2543_after.mp4
First example works on both videos, second one only after fix.
Test code and steps to reproduce
Run example app, open
Test2543.Checklist