Migrate `next` to `main` #3303

m-bert · 2024-12-20T09:37:09Z

Description

This PR migrates changed from next branch into main.

Test plan

Most of those commits are deprecations, to check get/set run example on web.

## Description This PR deprecates `Touchable` components in our repo ## Test plan Try importing any `Touchable` (or its `props`). After importing look at the console. --------- Co-authored-by: Jakub Piasecki <[email protected]>

## Description #3260 introduced a regression to the `Gesture Handlers`'s `TouchableNativeFeedback` component. The component used to be a direct reference to the `TouchableNativeFeedback`, which has a [couple of static methods](https://reactnative.dev/docs/touchablenativefeedback#methods). When it was replaced with a function component, the static methods got removed, leaving only the render function of the `TouchableNativeFeedback`. ## Test plan See how the type errors in the `example/src/release_tests/touchables/index.tsx` are resolved.

## Description This PR deprecates old Gesture Handler API. ## Test plan Try importing any handler from old API.

In this PR I've migrated our handlers into `get`/`set` functions instead of traditional getters and setters convention (like in `Java`). Run web example

latekvo · 2024-12-20T11:26:46Z

Do you think it'd make sense to rebase these changes onto main instead of squashing them?
While I don't think it's a big deal, I'm not a big fan of squashing 4 PRs and some other changes together instead of keeping them separate

m-bert · 2024-12-20T13:05:56Z

Do you think it'd make sense to rebase these changes onto main instead of squashing them?

In our discussion with @j-piasecki we decided that it would be better to cherry-pick those changes into separate commit.

latekvo · 2025-01-10T10:34:35Z

Should we close this PR?

m-bert · 2025-01-20T08:27:47Z

Should we close this PR?

Why is that?

latekvo · 2025-01-20T09:52:41Z

Why is that?

Just asking, since I understood you plan to either cherrypick those changes directly to main without a need for PR, or open a separate PR for all of these changes separately:

In our discussion with @j-piasecki we decided that it would be better to cherry-pick those changes into separate commit.

m-bert · 2025-01-20T10:03:13Z

What I meant was that we decided to cherry-pick those commits into one PR (this one) and then merge it. At least this is what we planned to do back then 😅

latekvo · 2025-01-20T10:16:24Z

That makes sense, should we merge it then?

Also, what is this commit doing in this PR? It doesn't seem relevant to the rest of the cherry-picked PRs.

Besides that change, I think all of these PRs have been already extensively tested individually.

m-bert · 2025-01-20T10:35:48Z

Also, what is this commit doing in this PR? It doesn't seem relevant to the rest of the cherry-picked PRs.

How does it not seem relevant? It is strictly connected to get/set migration, as without this commit there's infinite recursion while trying to access instance of InteractionsManager

That makes sense, should we merge it then?

I think so, maybe before next release (cc @j-piasecki)

j-piasecki · 2025-01-21T10:31:35Z

src/web/tools/VelocityTracker.ts

@@ -84,7 +84,7 @@ export default class VelocityTracker {
    return null;
  }

-  public getVelocity(): [number, number] {
+  public get velocity() {


Doesn't this change the return type?

It does to number[]. Changed in b7b4eaa

j-piasecki · 2025-01-21T10:32:06Z

I think so, maybe before next release

We are before the next release 😄

latekvo

Only one nit-pick

src/web/tools/Vector.ts

j-piasecki

🙈

This reverts commit ce10992.

m-bert and others added 4 commits December 20, 2024 10:27

Deprecate Touchable components (#3260)

82d62c0

## Description This PR deprecates `Touchable` components in our repo ## Test plan Try importing any `Touchable` (or its `props`). After importing look at the console. --------- Co-authored-by: Jakub Piasecki <[email protected]>

Deprecate old API (#3262)

61aaef9

## Description This PR deprecates old Gesture Handler API. ## Test plan Try importing any handler from old API.

[Web] Migrate to get and set (#3263)

8f34660

In this PR I've migrated our handlers into `get`/`set` functions instead of traditional getters and setters convention (like in `Java`). Run web example

m-bert requested review from j-piasecki and latekvo December 20, 2024 09:38

m-bert changed the title ~~Migrate next to main.~~ Migrate next to main Dec 20, 2024

m-bert marked this pull request as draft December 20, 2024 09:40

Fix recursion error

09d0e85

m-bert marked this pull request as ready for review December 20, 2024 09:49

Merge branch 'main' into @mbert/move-changes-from-next-to-main

1b1ec39

Merge branch 'main' into @mbert/move-changes-from-next-to-main

7b766f7

j-piasecki reviewed Jan 21, 2025

View reviewed changes

latekvo approved these changes Jan 21, 2025

View reviewed changes

src/web/tools/Vector.ts Show resolved Hide resolved

m-bert added 2 commits January 22, 2025 10:08

Merge branch 'main' into @mbert/move-changes-from-next-to-main

1a174a4

Add return type

b7b4eaa

j-piasecki approved these changes Jan 22, 2025

View reviewed changes

Merge branch 'main' into @mbert/move-changes-from-next-to-main

4a61d87

m-bert merged commit ce10992 into main Jan 27, 2025
2 checks passed

m-bert deleted the @mbert/move-changes-from-next-to-main branch January 27, 2025 14:14

m-bert added a commit that referenced this pull request Jan 28, 2025

Revert "Migrate next to main (#3303)"

73baa84

This reverts commit ce10992.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Migrate `next` to `main` #3303

Migrate `next` to `main` #3303

Uh oh!

m-bert commented Dec 20, 2024

Uh oh!

latekvo commented Dec 20, 2024 •

edited

Loading

Uh oh!

m-bert commented Dec 20, 2024

Uh oh!

latekvo commented Jan 10, 2025

Uh oh!

m-bert commented Jan 20, 2025

Uh oh!

latekvo commented Jan 20, 2025 •

edited

Loading

Uh oh!

m-bert commented Jan 20, 2025

Uh oh!

latekvo commented Jan 20, 2025 •

edited

Loading

Uh oh!

m-bert commented Jan 20, 2025

Uh oh!

j-piasecki Jan 21, 2025

Uh oh!

m-bert Jan 22, 2025

Uh oh!

j-piasecki commented Jan 21, 2025

Uh oh!

latekvo left a comment •

edited

Loading

Uh oh!

Uh oh!

j-piasecki left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Migrate next to main #3303

Migrate next to main #3303

Uh oh!

Conversation

m-bert commented Dec 20, 2024

Description

Test plan

Uh oh!

latekvo commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-bert commented Dec 20, 2024

Uh oh!

latekvo commented Jan 10, 2025

Uh oh!

m-bert commented Jan 20, 2025

Uh oh!

latekvo commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-bert commented Jan 20, 2025

Uh oh!

latekvo commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-bert commented Jan 20, 2025

Uh oh!

j-piasecki Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

m-bert Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

j-piasecki commented Jan 21, 2025

Uh oh!

latekvo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

j-piasecki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Migrate `next` to `main` #3303

Migrate `next` to `main` #3303

latekvo commented Dec 20, 2024 •

edited

Loading

latekvo commented Jan 20, 2025 •

edited

Loading

latekvo commented Jan 20, 2025 •

edited

Loading

latekvo left a comment •

edited

Loading