[Web] Migrate to get and set
#3263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
requested review from
latekvo and
j-piasecki
and removed request for
latekvo
j-piasecki
reviewed
Dec 6, 2024
latekvo
reviewed
Dec 9, 2024
j-piasecki
reviewed
Dec 13, 2024
j-piasecki
approved these changes
Dec 16, 2024
I'll wait for his approval 😅 |
m-bert
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've migrated our handlers into
get/setfunctions instead of traditional getters and setters convention (like inJava).Test plan
Run web example