Skip to content

fix: fixed issue with disconnect not happening #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

poneciak57
Copy link
Contributor

@poneciak57 poneciak57 commented Aug 6, 2025

Introduced new ConnectionType::DISCONNECT_ALL which ensures that connection checking happens on the audio thread and some sort of guarantee sequential execution of connect & disconnect

Closes RNAA-194
Closes #581

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

Introduced new `ConnectionType::DISCONNECT_ALL` which ensures that
connection checking happens on the audio thread and some sort of
guarantee sequential execution of connect & disconnect
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maciejmakowski2003 maciejmakowski2003 merged commit d65d4ba into software-mansion:main Aug 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connecting then disconnecting an audio node in rapid succession causes disconnection to fail
2 participants