Don't use strtobool from distutils #2144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akx
force-pushed
the
drop-distutils-dep
branch
from
b1e6de6 to
e1abfd6
Compare
|
|
|
It would be great if this PR can also address env_helper |
|
@Swastik-SQED Sure – this PR is open for maintainers to edit as they see fit. That file was added 2 months ago, this PR was created nearly a year ago... I didn't have a crystal ball at that point :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this question – one shouldn't need
distutils/setuptoolsjust to see if a string feels truthy.The set of truthy-feeling strings was borrowed from
setuptools.Fixes #2091.