Skip to content

Update k6-38-0e-0b-dsc panel and fix touchscreen for sweet_k6a aka Redmi Note 12 Pro 4G #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update k6-38-0e-0b-dsc panel and fix touchscreen for sweet_k6a aka Redmi Note 12 Pro 4G #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e12721d
drm: panel: Update panel-k6-38-0e-0b-dsc
Vilez0 Apr 28, 2024
7c24e0e
fixup! arm64: dts: qcom: sm7150: fix touchscreen for Redmi Note 12 Pr…
Vilez0 Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions arch/arm64/boot/dts/qcom/sm7150-xiaomi-sweet_k6a.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
reg = <0x5d>;
interrupt-parent = <&tlmm>;
interrupts = <9 IRQ_TYPE_NONE>;
pinctrl-0 = <&ts_int_active &ts_reset_active>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reset is required. Give me at least one reason why this should be dropped

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U remember the irq head checksum error in dmesg, this reset cause it
And downstream dtb doesn't have reset

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U remember the irq head checksum error in dmesg, this reset cause it And downstream dtb doesn't have reset

Sorry, I don't remember. Downstream uses this anyway. Downstream has in one pinctrl node both pins at once. This is fundamentally wrong, so it is corrected here. In fact, the irg pin should have an input only configuration, and the reset pin should have an output configuration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-04-29 21-02-08
As you can see gpio8 and gpio9. In mainline these are irq and reset which have been splitted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't believe such a high current is needed, perhaps we could test all devices at 8mA instead of 16mA. I'm almost 99% sure that this will work, tests are just always needed. @Gelbpunkt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xiaomi didnt want to bother. But this causes high load on gpio

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't believe such a high current is needed, perhaps we could test all devices at 8mA instead of 16mA. I'm almost 99% sure that this will work, tests are just always needed. @Gelbpunkt

Yeah 16 is a lot. I'll try 8 when I have some time, it will probably work fine

pinctrl-0 = <&ts_int_active>;
pinctrl-1 = <&ts_int_suspend &ts_reset_suspend>;
pinctrl-names = "default", "sleep";
vtouch-supply = <&vreg_l7c_3p0>;
Expand All @@ -115,9 +115,10 @@
goodix,reset-gpio = <&tlmm 8 GPIO_ACTIVE_HIGH>;
goodix,irq-gpio = <&tlmm 9 IRQ_TYPE_NONE>;
goodix,irq-flags = <2>; /* trigger falling;*/
goodix,panel-max-x = <1079>;
goodix,panel-max-y = <2399>;
goodix,panel-max-x = <8639>;
goodix,panel-max-y = <19199>;
goodix,panel-max-w = <256>;
goodix,panel-max-p = <256>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik the driver doesnt wait for goodix,panel-max-p values

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sm7150-mainline/linux/blob/v6.8.6/drivers/input/touchscreen/gtx8/goodix_ts_i2c.c#L99-L117

goodix,power-on-delay-us = <100>; /* 0.1ms */
goodix,power-off-delay-us = <5000>; /* 50ms */
};
Expand Down
Loading