Update k6-38-0e-0b-dsc panel and fix touchscreen for sweet_k6a aka Redmi Note 12 Pro 4G #28

Vilez0 · 2024-04-28T14:46:35Z

No description provided.

…o 4G

JIaxyga · 2024-04-28T16:17:56Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

@@ -18,415 +18,415 @@
 #include <drm/drm_panel.h>

 struct k6_38_0e_0b_dsc {
-	struct drm_panel panel;


Use tabs instead of spaces

JIaxyga · 2024-04-28T16:20:47Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

 };

-static inline
-struct k6_38_0e_0b_dsc *to_k6_38_0e_0b_dsc(struct drm_panel *panel)


Follow the latest upstream driver styles (Leave it as it was in the previous version)

JIaxyga · 2024-04-28T16:21:08Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

 }

-static void k6_38_0e_0b_dsc_reset(struct k6_38_0e_0b_dsc *ctx)
+static void k6_38_0e_0b_dsc_reset(struct k6_38_0e_0b_dsc* ctx)


JIaxyga · 2024-04-28T16:21:23Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

 }

-static int k6_38_0e_0b_dsc_on(struct k6_38_0e_0b_dsc *ctx)


JIaxyga · 2024-04-28T16:23:39Z

arch/arm64/boot/dts/qcom/sm7150-xiaomi-sweet_k6a.dts

@@ -105,7 +105,7 @@
 		reg = <0x5d>;
 		interrupt-parent = <&tlmm>;
 		interrupts = <9 IRQ_TYPE_NONE>;
-		pinctrl-0 = <&ts_int_active &ts_reset_active>;


This reset is required. Give me at least one reason why this should be dropped

U remember the irq head checksum error in dmesg, this reset cause it
And downstream dtb doesn't have reset

U remember the irq head checksum error in dmesg, this reset cause it And downstream dtb doesn't have reset

Sorry, I don't remember. Downstream uses this anyway. Downstream has in one pinctrl node both pins at once. This is fundamentally wrong, so it is corrected here. In fact, the irg pin should have an input only configuration, and the reset pin should have an output configuration

As you can see gpio8 and gpio9. In mainline these are irq and reset which have been splitted

I actually don't believe such a high current is needed, perhaps we could test all devices at 8mA instead of 16mA. I'm almost 99% sure that this will work, tests are just always needed. @Gelbpunkt

Xiaomi didnt want to bother. But this causes high load on gpio

I actually don't believe such a high current is needed, perhaps we could test all devices at 8mA instead of 16mA. I'm almost 99% sure that this will work, tests are just always needed. @Gelbpunkt

Yeah 16 is a lot. I'll try 8 when I have some time, it will probably work fine

JIaxyga · 2024-04-28T16:24:30Z

arch/arm64/boot/dts/qcom/sm7150-xiaomi-sweet_k6a.dts

 		goodix,panel-max-w = <256>;
+        	goodix,panel-max-p = <256>;


afaik the driver doesnt wait for goodix,panel-max-p values

https://github.com/sm7150-mainline/linux/blob/v6.8.6/drivers/input/touchscreen/gtx8/goodix_ts_i2c.c#L99-L117

JIaxyga · 2024-04-28T16:28:00Z

Take into account the recently applied driver from David: 9a314ea

ungeskriptet · 2024-04-28T16:36:59Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

+    struct mipi_dsi_device* dsi;
+    struct drm_dsc_config dsc;
+    struct gpio_desc* reset_gpio;
+    bool prepared;


You can drop the prepared bool, it's being handled by the core DRM driver

ungeskriptet · 2024-04-28T16:40:26Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

+    mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+    connector->display_info.width_mm = mode->width_mm;
+    connector->display_info.height_mm = mode->height_mm;
+    drm_mode_probed_add(connector, mode);


Please switch to drm_connector_helper_get_modes_fixed() in the _get_modes function

ungeskriptet · 2024-04-28T16:46:55Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

+    ctx->dsc.bits_per_pixel = 8 << 4; /* 4 fractional bits */
+    ctx->dsc.block_pred_enable = true;
+
+    ret = mipi_dsi_attach(dsi);


If you switch to devm_mipi_dsi_attach() here you can drop the detaching code in the _remove function. It will detach for you automatically

ungeskriptet · 2024-04-28T17:18:37Z

drivers/gpu/drm/panel/panel-k6-38-0e-0b-dsc.c

 }

 static const struct of_device_id k6_38_0e_0b_dsc_of_match[] = {
-	{ .compatible = "mdss,k6-38-0e-0b-dsc" }, // FIXME
-	{ /* sentinel */ }
+    { .compatible = "mdss,k6-38-0e-0b-dsc" }, // FIXME


Do you know the actual supplier of this panel? After a bit of digging on Google I found out that Redmi Note 10 and 12 Pro 4G should have an AMS667YR01 panel, which is probably a Samsung panel if we go by the AMS- prefix. Either way I think this compatible should be renamed. Something like xiaomi,sweet-k6a-samsung-panel or xiaomi,sweet-k6a-panel if you don't know the supplier would be appreciated

…poll Use spin_lock_irqsave and spin_unlock_irqrestore instead of spin_lock and spin_unlock in mtk_star_emac driver to avoid spinlock recursion occurrence that can happen when enabling the DMA interrupts again in rx/tx poll. ``` BUG: spinlock recursion on CPU#0, swapper/0/0 lock: 0xffff00000db9cf20, .magic: dead4ead, .owner: swapper/0/0, .owner_cpu: 0 CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.15.0-rc2-next-20250417-00001-gf6a27738686c-dirty #28 PREEMPT Hardware name: MediaTek MT8365 Open Platform EVK (DT) Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x60/0x80 dump_stack+0x18/0x24 spin_dump+0x78/0x88 do_raw_spin_lock+0x11c/0x120 _raw_spin_lock+0x20/0x2c mtk_star_handle_irq+0xc0/0x22c [mtk_star_emac] __handle_irq_event_percpu+0x48/0x140 handle_irq_event+0x4c/0xb0 handle_fasteoi_irq+0xa0/0x1bc handle_irq_desc+0x34/0x58 generic_handle_domain_irq+0x1c/0x28 gic_handle_irq+0x4c/0x120 do_interrupt_handler+0x50/0x84 el1_interrupt+0x34/0x68 el1h_64_irq_handler+0x18/0x24 el1h_64_irq+0x6c/0x70 regmap_mmio_read32le+0xc/0x20 (P) _regmap_bus_reg_read+0x6c/0xac _regmap_read+0x60/0xdc regmap_read+0x4c/0x80 mtk_star_rx_poll+0x2f4/0x39c [mtk_star_emac] __napi_poll+0x38/0x188 net_rx_action+0x164/0x2c0 handle_softirqs+0x100/0x244 __do_softirq+0x14/0x20 ____do_softirq+0x10/0x20 call_on_irq_stack+0x24/0x64 do_softirq_own_stack+0x1c/0x40 __irq_exit_rcu+0xd4/0x10c irq_exit_rcu+0x10/0x1c el1_interrupt+0x38/0x68 el1h_64_irq_handler+0x18/0x24 el1h_64_irq+0x6c/0x70 cpuidle_enter_state+0xac/0x320 (P) cpuidle_enter+0x38/0x50 do_idle+0x1e4/0x260 cpu_startup_entry+0x34/0x3c rest_init+0xdc/0xe0 console_on_rootfs+0x0/0x6c __primary_switched+0x88/0x90 ``` Fixes: 0a8bd81 ("net: ethernet: mtk-star-emac: separate tx/rx handling with two NAPIs") Signed-off-by: Louis-Alexis Eyraud <[email protected]> Reviewed-by: Maxime Chevallier <[email protected]> Acked-by: Bartosz Golaszewski <[email protected]> Link: https://patch.msgid.link/20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-1-f3fde2e529d8@collabora.com Signed-off-by: Jakub Kicinski <[email protected]>

…poll' Louis-Alexis Eyraud says: ==================== net: ethernet: mtk-star-emac: fix several issues on rx/tx poll This patchset fixes two issues with the mtk-star-emac driver. The first patch fixes spin lock recursion issues I've observed on the Mediatek Genio 350-EVK board using this driver when the Ethernet functionality is enabled on the board (requires a correct jumper and DIP switch configuration, as well as enabling the device in the devicetree). The issues can be easily reproduced with apt install or ssh commands especially and with the CONFIG_DEBUG_SPINLOCK parameter, when one occurs, there is backtrace similar to this: ``` BUG: spinlock recursion on CPU#0, swapper/0/0 lock: 0xffff00000db9cf20, .magic: dead4ead, .owner: swapper/0/0, .owner_cpu: 0 CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.15.0-rc2-next-20250417-00001-gf6a27738686c-dirty #28 PREEMPT Hardware name: MediaTek MT8365 Open Platform EVK (DT) Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x60/0x80 dump_stack+0x18/0x24 spin_dump+0x78/0x88 do_raw_spin_lock+0x11c/0x120 _raw_spin_lock+0x20/0x2c mtk_star_handle_irq+0xc0/0x22c [mtk_star_emac] __handle_irq_event_percpu+0x48/0x140 handle_irq_event+0x4c/0xb0 handle_fasteoi_irq+0xa0/0x1bc handle_irq_desc+0x34/0x58 generic_handle_domain_irq+0x1c/0x28 gic_handle_irq+0x4c/0x120 do_interrupt_handler+0x50/0x84 el1_interrupt+0x34/0x68 el1h_64_irq_handler+0x18/0x24 el1h_64_irq+0x6c/0x70 regmap_mmio_read32le+0xc/0x20 (P) _regmap_bus_reg_read+0x6c/0xac _regmap_read+0x60/0xdc regmap_read+0x4c/0x80 mtk_star_rx_poll+0x2f4/0x39c [mtk_star_emac] __napi_poll+0x38/0x188 net_rx_action+0x164/0x2c0 handle_softirqs+0x100/0x244 __do_softirq+0x14/0x20 ____do_softirq+0x10/0x20 call_on_irq_stack+0x24/0x64 do_softirq_own_stack+0x1c/0x40 __irq_exit_rcu+0xd4/0x10c irq_exit_rcu+0x10/0x1c el1_interrupt+0x38/0x68 el1h_64_irq_handler+0x18/0x24 el1h_64_irq+0x6c/0x70 cpuidle_enter_state+0xac/0x320 (P) cpuidle_enter+0x38/0x50 do_idle+0x1e4/0x260 cpu_startup_entry+0x34/0x3c rest_init+0xdc/0xe0 console_on_rootfs+0x0/0x6c __primary_switched+0x88/0x90 ``` The second patch is a cleanup patch to fix a inconsistency in the mtk_star_rx_poll function between the napi_complete_done api usage and its description in documentation. I've tested this patchset on Mediatek Genio 350-EVK board with a kernel based on linux-next (tag: next-20250422). v1: https://lore.kernel.org/20250422-mtk_star_emac-fix-spinlock-recursion-issue-v1-0-1e94ea430360@collabora.com ==================== Link: https://patch.msgid.link/20250424-mtk_star_emac-fix-spinlock-recursion-issue-v2-0-f3fde2e529d8@collabora.com Signed-off-by: Jakub Kicinski <[email protected]>

Recent kernels complain about a missing lock in k3-udma.c when the lock validator is enabled: [ 4.128073] WARNING: CPU: 0 PID: 746 at drivers/dma/ti/../virt-dma.h:169 udma_start.isra.0+0x34/0x238 [ 4.137352] CPU: 0 UID: 0 PID: 746 Comm: kworker/0:3 Not tainted 6.12.9-arm64 #28 [ 4.144867] Hardware name: pp-v12 (DT) [ 4.148648] Workqueue: events udma_check_tx_completion [ 4.153841] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 4.160834] pc : udma_start.isra.0+0x34/0x238 [ 4.165227] lr : udma_start.isra.0+0x30/0x238 [ 4.169618] sp : ffffffc083cabcf0 [ 4.172963] x29: ffffffc083cabcf0 x28: 0000000000000000 x27: ffffff800001b005 [ 4.180167] x26: ffffffc0812f0000 x25: 0000000000000000 x24: 0000000000000000 [ 4.187370] x23: 0000000000000001 x22: 00000000e21eabe9 x21: ffffff8000fa0670 [ 4.194571] x20: ffffff8001b6bf00 x19: ffffff8000fa0430 x18: ffffffc083b95030 [ 4.201773] x17: 0000000000000000 x16: 00000000f0000000 x15: 0000000000000048 [ 4.208976] x14: 0000000000000048 x13: 0000000000000000 x12: 0000000000000001 [ 4.216179] x11: ffffffc08151a240 x10: 0000000000003ea1 x9 : ffffffc08046ab68 [ 4.223381] x8 : ffffffc083cabac0 x7 : ffffffc081df3718 x6 : 0000000000029fc8 [ 4.230583] x5 : ffffffc0817ee6d8 x4 : 0000000000000bc0 x3 : 0000000000000000 [ 4.237784] x2 : 0000000000000000 x1 : 00000000001fffff x0 : 0000000000000000 [ 4.244986] Call trace: [ 4.247463] udma_start.isra.0+0x34/0x238 [ 4.251509] udma_check_tx_completion+0xd0/0xdc [ 4.256076] process_one_work+0x244/0x3fc [ 4.260129] process_scheduled_works+0x6c/0x74 [ 4.264610] worker_thread+0x150/0x1dc [ 4.268398] kthread+0xd8/0xe8 [ 4.271492] ret_from_fork+0x10/0x20 [ 4.275107] irq event stamp: 220 [ 4.278363] hardirqs last enabled at (219): [<ffffffc080a27c7c>] _raw_spin_unlock_irq+0x38/0x50 [ 4.287183] hardirqs last disabled at (220): [<ffffffc080a1c154>] el1_dbg+0x24/0x50 [ 4.294879] softirqs last enabled at (182): [<ffffffc080037e68>] handle_softirqs+0x1c0/0x3cc [ 4.303437] softirqs last disabled at (177): [<ffffffc080010170>] __do_softirq+0x1c/0x28 [ 4.311559] ---[ end trace 0000000000000000 ]--- This commit adds the missing locking. Fixes: 25dcb5d ("dmaengine: ti: New driver for K3 UDMA") Cc: Peter Ujfalusi <[email protected]> Cc: Vignesh Raghavendra <[email protected]> Cc: Vinod Koul <[email protected]> Cc: [email protected] Cc: [email protected] Signed-off-by: Ronald Wahl <[email protected]> Acked-by: Peter Ujfalusi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>

Vilez0 added 2 commits April 28, 2024 17:42

drm: panel: Update panel-k6-38-0e-0b-dsc

e12721d

fixup! arm64: dts: qcom: sm7150: fix touchscreen for Redmi Note 12 Pr…

7c24e0e

…o 4G

JIaxyga requested changes Apr 28, 2024

View reviewed changes

ungeskriptet reviewed Apr 28, 2024

View reviewed changes

Vilez0 closed this Apr 29, 2024

Update k6-38-0e-0b-dsc panel and fix touchscreen for sweet_k6a aka Redmi Note 12 Pro 4G #28

Update k6-38-0e-0b-dsc panel and fix touchscreen for sweet_k6a aka Redmi Note 12 Pro 4G #28

Uh oh!

Conversation

Vilez0 commented Apr 28, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JIaxyga commented Apr 28, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!