Feature: Tailwind V4 #3189
Merged
Feature: Tailwind V4 #3189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: da0009d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Sarenor
approved these changes
Feb 24, 2025
sites/next.skeleton.dev/src/content/docs/get-started/migrate-v3.mdx
Outdated
Show resolved
Hide resolved
sites/next.skeleton.dev/src/content/docs/get-started/migrate-v3.mdx
Outdated
Show resolved
Hide resolved
sites/next.skeleton.dev/src/content/docs/get-started/migrate-v3.mdx
Outdated
Show resolved
Hide resolved
sites/next.skeleton.dev/src/content/docs/get-started/migrate-v3.mdx
Outdated
Show resolved
Hide resolved
…/skeleton into feature/tailwind-v4
…/skeleton into feature/tailwind-v4
Comment on lines
+84
to
+87
| /* .focused { | ||
| @apply ring-[2px] ring-surface-950 dark:ring-surface-50 ring-inset; | ||
| } */ | ||
| } |
There was a problem hiding this comment.
should this still be commented out/hasn't been converted to standard css yet?
There was a problem hiding this comment.
Let's move this to the Zag 1.0 PR for consideration. This will be part of a large discussion around how Zag depends on CSS custom properties to define certain component values and styles. In this case the focus state outline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #3195
Description
This is the rewrite of the Skeleton core package to support Tailwind v4, previously referred to as the Skeleton Tailwind plugin. It utilizes Vite for bundling and SCSS (aka Sass) for authoring our styles.
Overall Progress
High level overview of the entire scope of this pull request. When all items are green, this PR is ready for review.
Core Package Features
This represents progress specific to the core package.
Base
SpacingThemes
Animations
Utilities
GradientsOptional