Skip to content

Allow numeric literal as property name #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2017
Merged

Allow numeric literal as property name #55

merged 4 commits into from
Dec 4, 2017

Conversation

bleis-tift
Copy link
Contributor

related: #35

@sjrd
Copy link
Owner

sjrd commented Dec 3, 2017

This should probably be revisited after #47, as there will be conflicts with the code there, and some of the same comments apply here.

@sjrd
Copy link
Owner

sjrd commented Dec 3, 2017

#47 has now been merged, so this can now be rebased on top of master to address the conflicts and adapt to the IntLiteral/DoubleLiteral from #47.

@sjrd
Copy link
Owner

sjrd commented Dec 4, 2017

The .ts files in the tests will also need to be renamed to .d.ts to adapt to the changes in #56.

@bleis-tift bleis-tift force-pushed the allow-numeric-literal-as-property-name branch from 25e4619 to e2496f1 Compare December 4, 2017 15:24
@bleis-tift
Copy link
Contributor Author

rebased.

sjrd
sjrd approved these changes Dec 4, 2017
View reviewed changes
Copy link
Owner

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks.

@sjrd sjrd merged commit 6d996f7 into sjrd:master Dec 4, 2017
@bleis-tift bleis-tift deleted the allow-numeric-literal-as-property-name branch December 5, 2017 10:03
exoego referenced this pull request in exoego/scala-js-ts-importer Mar 23, 2018
@bleis-tift
Allow numeric literal as property name (#55)
1a2e657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bleis-tift @sjrd