Add number literal type #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Dec 3, 2017
| @@ -107,7 +107,7 @@ object Trees { | |||
|
|
|||
| case class BooleanLiteral(value: Boolean) extends Literal | |||
|
|
|||
| case class NumberLiteral(value: Double) extends Literal | |||
| case class NumberLiteral(value: Double, isValidInt: Boolean) extends Literal | |||
There was a problem hiding this comment.
This structure is a bit weird, IMO. Have you considered having two separate
case class IntLiteral(value: Int) extends Literal
case class DoubleLiteral(value: Double) extends Literalinstead?
There was a problem hiding this comment.
Refactored in 8bf944f
| @@ -290,6 +295,12 @@ class TSDefParser extends StdTokenParsers with ImplicitConversions { | |||
| lazy val stringLiteral: Parser[StringLiteral] = | |||
| stringLit ^^ StringLiteral | |||
|
|
|||
| lazy val numberLiteral: Parser[NumberLiteral] = | |||
| numericLit ^^ {s => | |||
There was a problem hiding this comment.
Coding style: missing space between { and s.
There was a problem hiding this comment.
Oops. Fixed in 8bf944f
exoego
force-pushed
the
number-literal-type
branch
from
8bf944f to
3fe60c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the number literal type to
IntorDouble.Intif it is valid-integer and does not have the fraction part, , e.g.1or0x1Doubleif it has the fraction part, e.g.0.1,1.0or00000000001001000110100Compared to the string literal type, the usage seems very low... but not zero, e.g. Pixi.