Release: v4.2.0 #292

ForliyScarlet · 2025-08-22T09:15:43Z

No description provided.

…le after construction close #266

支持 ChannelKickoutApi (/channel/kickout)

…bot/kook/api/channel/GetChannelUserListApi.kt Co-authored-by: Copilot <[email protected]>

…st-API 支持获取语音频道用户列表api

…bot/kook/api/channel/ChannelKickoutApiTest.kt Co-authored-by: Copilot <[email protected]>

…-API 改进 ChannelKickoutApi 的部分相关测试

close #264

…bot/kook/api/channel/ChannelMoveUserApi.kt Co-authored-by: Copilot <[email protected]>

…er-API 支持频道之间移动用户api

close #268

支持语音相关接口api

- Added support for managing voice channel members (e.g., move and kickout functionalities). - Implemented the KookVoiceMember interface and its core logic. - Integrated voice channel handling in the guild structure. - Updated related APIs for consistency.

增加 KookVoiceChannel 和 KookVoiceMember 等语音频道相关API支持

Copilot

Pull Request Overview

This pull request introduces comprehensive voice channel support to the KOOK component, adding new classes and interfaces to manage voice channels and their members.

Implementation of KookVoiceChannel interface with voice channel management capabilities
Addition of KookVoiceMember interface for voice-specific member operations
Creation of new API classes for voice channel operations including join, leave, move user, and kickout

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`KookVoiceChannel.kt`	New interface defining voice channel functionality with member management
`KookVoiceMember.kt`	New interface for voice channel members with move and kickout operations
`KookVoiceChannelImpl.kt`	Implementation of voice channel with user management and member operations
`KookVoiceMemberImpl.kt`	Implementation of voice member with delegation pattern
`KookChatCapableChannel.kt`	New abstract base for channels that support messaging
`Utils.kt`	Utility functions for channel type conversion and category management
Various API classes	New voice-related API implementations for backend operations
Tests	Comprehensive test coverage for new voice APIs

Comments suppressed due to low confidence (1)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-22T09:17:34Z

...core/src/commonMain/kotlin/love/forte/simbot/component/kook/internal/KookVoiceChannelImpl.kt

+                val delegateMember = bot.internalMember(guildId = source.guildId, userId = it.id)
+                logger.trace("Processing voice channel user-list(id={})'s delegate member: {}", it.id, delegateMember)
+                if (delegateMember == null) {
+                    logger.warn("Delegate member for voice channel's user(id={}) is null.", it)


The log message uses it which refers to the VoiceChannelUser object, but the message suggests it should show the user ID. Consider changing to it.id for clearer logging.

Suggested change

logger.warn("Delegate member for voice channel's user(id={}) is null.", it)

logger.warn("Delegate member for voice channel's user(id={}) is null.", it.id)

Copilot · 2025-08-22T09:17:34Z

...kook-core/src/commonMain/kotlin/love/forte/simbot/component/kook/bot/internal/KookBotImpl.kt

@@ -98,7 +100,7 @@ internal class KookBotImpl(

        return try {
            id.literal == botUserInfo.id
-        } catch (e: IllegalStateException) {
+        } catch (_: IllegalStateException) {
            // ignore match and return true


Using underscore for unused exception parameter is good practice, but the comment should be updated. The catch block comment says 'ignore match and return true' but this seems backwards - it should probably be 'ignore exception and return false' or explain why true is returned on exception.

Suggested change

// ignore match and return true

// ignore exception and return true

Copilot · 2025-08-22T09:17:35Z

simbot-component-kook-api/src/commonMain/kotlin/love/forte/simbot/kook/api/ApiResult.kt

+        "ApiResult(" +
+                "code=$code, " +
+                "message=$message, " +
+                "data=$data, " +


[nitpick] The toString() method improvement adds null checks for uninitialized properties, but the data field is not checked like the others (httpStatus, rateLimit, raw). Consider adding a similar null check for data if it can also be uninitialized.

Suggested change

"data=$data, " +

"data=${dataOrNull ?: "<Not Initialized>"}, " +

ForliyScarlet · 2025-08-22T09:27:05Z

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

ForteScarlet and others added 25 commits August 18, 2025 13:36

feat(api): 支持 ChannelKickoutApi (/channel/kickout)

3e52a3c

feat(api): making ChannelKickoutApi constructor parameters inaccessib…

f72c588

…le after construction close #266

Merge pull request #284 from simple-robot/dev/channel-kickout

b169131

支持 ChannelKickoutApi (/channel/kickout)

feat(api): Support /channel/user-list

9980b36

Update simbot-component-kook-api/src/commonMain/kotlin/love/forte/sim…

c187965

…bot/kook/api/channel/GetChannelUserListApi.kt Co-authored-by: Copilot <[email protected]>

Merge pull request #286 from simple-robot/dev/support-channel-user-li…

065d36f

…st-API 支持获取语音频道用户列表api

test(api): 改进 ChannelKickoutApi 的部分相关测试

b805c12

improve(api): 改进 identifyNum 的默认值获取

5b5cf10

build: next version to 4.2.0

9c85658

Update simbot-component-kook-api/src/commonTest/kotlin/love/forte/sim…

2c65d80

…bot/kook/api/channel/ChannelKickoutApiTest.kt Co-authored-by: Copilot <[email protected]>

Update simbot-component-kook-api/src/commonTest/kotlin/love/forte/sim…

9eeeade

…bot/kook/api/channel/ChannelKickoutApiTest.kt Co-authored-by: Copilot <[email protected]>

Update simbot-component-kook-api/src/commonTest/kotlin/love/forte/sim…

7bc1540

…bot/kook/api/channel/ChannelKickoutApiTest.kt Co-authored-by: Copilot <[email protected]>

Merge pull request #287 from simple-robot/dev/support-channel-kickout…

5afc99d

…-API 改进 ChannelKickoutApi 的部分相关测试

feat(api): add support for ChannelMoveUserApi with tests

6263997

close #264

Update simbot-component-kook-api/src/commonMain/kotlin/love/forte/sim…

9ebbe47

…bot/kook/api/channel/ChannelMoveUserApi.kt Co-authored-by: Copilot <[email protected]>

Merge pull request #288 from simple-robot/dev/support-channel-move-us…

5d36e13

…er-API 支持频道之间移动用户api

feat(api): add voice channel APIs (join, list, leave) supported

996dd52

close #268

Merge pull request #289 from simple-robot/dev/support-voice-APIs

765fba9

支持语音相关接口api

feat(core): 增加新的 KookVoiceChannel 来描述一个语音频道的信息

632dace

build: api dump

74bf089

build(core): 补充桥接函数注解

4311397

test: Fix compilation failed

a005757

Merge pull request #291 from simple-robot/dev/support-kook-voice-channel

192aedc

增加 KookVoiceChannel 和 KookVoiceMember 等语音频道相关API支持

release: v4.2.0

16274fb

ForliyScarlet assigned ForteScarlet Aug 22, 2025

ForteScarlet requested review from ForteScarlet and Copilot and removed request for ForteScarlet August 22, 2025 09:15

ForteScarlet added the for-release label Aug 22, 2025

ForteScarlet previously approved these changes Aug 22, 2025

View reviewed changes

Copilot AI reviewed Aug 22, 2025

View reviewed changes

release: v4.2.0, fix logger msg

c2016ff

ForteScarlet dismissed their stale review via c2016ff August 22, 2025 09:18

ForteScarlet enabled auto-merge August 22, 2025 09:19

ForteScarlet approved these changes Aug 22, 2025

View reviewed changes

ForteScarlet merged commit 858c27e into main Aug 22, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Release: v4.2.0 #292

Release: v4.2.0 #292

Uh oh!

ForliyScarlet commented Aug 22, 2025 •

edited by ForteScarlet

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 22, 2025

Uh oh!

Copilot AI Aug 22, 2025

Uh oh!

Copilot AI Aug 22, 2025

Uh oh!

ForliyScarlet commented Aug 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

	logger.warn("Delegate member for voice channel's user(id={}) is null.", it)
	logger.warn("Delegate member for voice channel's user(id={}) is null.", it.id)

	// ignore match and return true
	// ignore exception and return true

	"data=$data, " +
	"data=${dataOrNull ?: "<Not Initialized>"}, " +

Uh oh!

Release: v4.2.0 #292

Release: v4.2.0 #292

Uh oh!

Conversation

ForliyScarlet commented Aug 22, 2025 • edited by ForteScarlet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

ForliyScarlet commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana Community for JVM

Uh oh!

Uh oh!

Uh oh!

ForliyScarlet commented Aug 22, 2025 •

edited by ForteScarlet

Loading

ForliyScarlet commented Aug 22, 2025 •

edited

Loading