支持频道之间移动用户api #288
支持频道之间移动用户api #288
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the "move user between channels" API endpoint (/channel/move-user) for the KOOK platform. The implementation allows moving users between voice channels programmatically.
- Implements
ChannelMoveUserApiclass with both List and varargs factory methods - Adds comprehensive test coverage for the new API functionality
- Updates the public API surface to expose the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ChannelMoveUserApi.kt | Main implementation of the channel move user API with serializable body and factory methods |
| ChannelMoveUserApiTest.kt | Comprehensive test suite covering API structure, serialization, and mock HTTP responses |
| simbot-component-kook-api.api | Public API surface updates to expose the new ChannelMoveUserApi class and methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...nent-kook-api/src/commonMain/kotlin/love/forte/simbot/kook/api/channel/ChannelMoveUserApi.kt
Outdated
Show resolved
Hide resolved
|
|
||
| assertTrue(result.isSuccess) | ||
| assertEquals(0, result.code) | ||
| assertEquals("操作成功", result.message) |
There was a problem hiding this comment.
[nitpick] Hardcoded Chinese success message makes the test brittle if the API response format changes. Consider using a constant or making the test more flexible about the exact message content.
| assertEquals("操作成功", result.message) | |
| assertTrue(result.message.contains("成功"), "Expected success message to contain '成功', but was '${result.message}'") |
Copilot uses AI. Check for mistakes.
| // Wrap in KOOK API result format | ||
| val apiResultJson = """{ | ||
| "code": 0, | ||
| "message": "操作成功", |
There was a problem hiding this comment.
[nitpick] Hardcoded Chinese success message is repeated in multiple tests. Consider extracting this to a constant to improve maintainability.
| "message": "操作成功", | |
| "message": "$SUCCESS_MESSAGE", |
Copilot uses AI. Check for mistakes.
Qodana Community for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
…bot/kook/api/channel/ChannelMoveUserApi.kt Co-authored-by: Copilot <[email protected]>
/channel/move-userclose #264