Skip to content

fetch timestamps before submitting to rekor #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woodruffw merged 3 commits into from
Jul 1, 2025
Merged

fetch timestamps before submitting to rekor #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2b2d96
fetch timestamps before submitting to rekor
ramonpetgrave64 Jul 1, 2025
c2e3f15
changelog self-lin
ramonpetgrave64 Jul 1, 2025
2a749c7
Merge branch 'main' into timestamp-first
ramonpetgrave64 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ All versions prior to 0.9.0 are untracked.
configure the used Sigstore instance [#1358]/(https://github.com/sigstore/sigstore-python/pull/1358)
* By default (when `--trust-config` is not used) the whole trust configuration now
comes from the TUF repository [#1363](https://github.com/sigstore/sigstore-python/pull/1363)
* If the user provided TSA urls, rfc3161 timestamps are now fetched **before** submitting
entries to rekor. [#1463](https://github.com/sigstore/sigstore-python/pull/1463)

### Removed
* API:
Expand Down
9 changes: 4 additions & 5 deletions sigstore/sign.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,6 @@ def _finalize_sign(
"""
Perform the common "finalizing" steps in a Sigstore signing flow.
"""
# Submit the proposed entry to the transparency log
entry = self._signing_ctx._rekor.create_entry(proposed_entry)

_logger.debug(f"Transparency log entry created with index: {entry.log_index}")

# If the user provided TSA urls, timestamps the response
signed_timestamp = []
for tsa_client in self._signing_ctx._tsa_clients:
Expand All @@ -193,6 +188,10 @@ def _finalize_sign(
f"Unable to use {tsa_client.url} to timestamp the bundle. Failed with {e}"
)

# Submit the proposed entry to the transparency log
entry = self._signing_ctx._rekor.create_entry(proposed_entry)
_logger.debug(f"Transparency log entry created with index: {entry.log_index}")

return Bundle._from_parts(cert, content, entry, signed_timestamp)

def sign_dsse(
Expand Down