fetch timestamps before submitting to rekor#1463
Merged
woodruffw merged 3 commits intosigstore:mainfrom Jul 1, 2025
Merged
Conversation
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Contributor
Author
|
@woodruffw @haydentherapper |
Hayden-IO
approved these changes
Jul 1, 2025
Contributor
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
This change should be a no-op for reliable, available infrastructure. Ordering wise, I agree with this change, since Rekor should record a finalized signing event, and timestamps are a part of a signing event.
Contributor
|
/gcbrun |
woodruffw
approved these changes
Jul 1, 2025
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
Nice, good catch. Thanks @ramonpetgrave64!
Member
|
(Thinking out loud, this is perhaps the kind of thing that would be good to have a conformance test for -- other clients are likely to make the same sequencing mistake here!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fetch timestamps before submitting to rekor.
Resolves #1459
Release Note
entries to rekor.
Documentation