Skip to content

fix(instance): ssh install-config server without public ip #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 1 commit into from
Jun 19, 2023
Merged

fix(instance): ssh install-config server without public ip #3223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal/namespaces/instance/v1/custom_ssh_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ It generate hosts for instance servers, baremetal, apple-silicon and bastions`,
// Fill hosts with servers
hosts := make([]sshconfig.Host, 0, len(servers))
for _, server := range servers {
if server.Address == "" {
continue
}
hosts = append(hosts, sshconfig.SimpleHost{
Name: server.Name,
Address: server.Address,
Expand Down Expand Up @@ -171,9 +174,14 @@ func sshConfigListServers(ctx context.Context, args *sshConfigRequest) ([]sshCon
pnIDs[j] = nic.PrivateNetworkID
}

serverAddress := ""
if server.PublicIP != nil {
serverAddress = server.PublicIP.Address.String()
}

servers[i] = sshConfigServer{
Name: server.Name,
Address: server.PublicIP.Address.String(),
Address: serverAddress,
PrivateNetworksID: pnIDs,
}
}
Expand Down