Skip to content

fix(instance): ssh install-config server without public ip#3223

Merged
remyleone merged 1 commit intoscaleway:masterfrom
Codelax:fix/ssh-install-config-no-public-ip
Jun 19, 2023
Merged

fix(instance): ssh install-config server without public ip#3223
remyleone merged 1 commit intoscaleway:masterfrom
Codelax:fix/ssh-install-config-no-public-ip

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Jun 19, 2023

scw instance ssh install-config would crash if an instance doesn't have a public ip

@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Jun 19, 2023
@Codelax Codelax self-assigned this Jun 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3223 (c6cb44f) into master (76f569c) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #3223      +/-   ##
==========================================
- Coverage   75.63%   75.63%   -0.01%     
==========================================
  Files         177      177              
  Lines       38441    38446       +5     
==========================================
+ Hits        29075    29078       +3     
- Misses       8299     8300       +1     
- Partials     1067     1068       +1     
Impacted Files Coverage Δ
...ternal/namespaces/instance/v1/custom_ssh_config.go 60.86% <71.42%> (-0.02%) ⬇️

@remyleone remyleone added this pull request to the merge queue Jun 19, 2023
Merged via the queue into scaleway:master with commit 23a6aa5 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants