Rollup of 10 pull requests #142878

GuillaumeGomez · 2025-06-22T15:35:38Z

Successful merges:

Merge unboxed trait object error suggestion into regular dyn incompat error #142458 (Merge unboxed trait object error suggestion into regular dyn incompat error)
Add a warning to LateContext::get_def_path #142593 (Add a warning to LateContext::get_def_path)
Add DesugaringKind::FormatLiteral #142594 (Add DesugaringKind::FormatLiteral)
Clean-up FnCtxt::is_destruct_assignment_desugaring #142740 (Clean-up FnCtxt::is_destruct_assignment_desugaring)
Port #[must_use] to new attribute parsing infrastructure #142780 (Port #[must_use] to new attribute parsing infrastructure)
Don't fail to parse a struct if a semicolon is used to separate fields #142798 (Don't fail to parse a struct if a semicolon is used to separate fields)
Add a few inline directives in rustc_serialize. #142856 (Add a few inline directives in rustc_serialize.)
remove few allow(dead_code) #142868 (remove few allow(dead_code))
cranelift: fix target feature name typo: "fxsr" #142874 (cranelift: fix target feature name typo: "fxsr")
Document why tidy checks if eslint is installed via npm #142877 (Document why tidy checks if eslint is installed via npm)

r? @ghost
@rustbot modify labels: rollup

… error

rewrite using let-chains

Signed-off-by: Jonathan Brouwer <[email protected]>

…rrors Merge unboxed trait object error suggestion into regular dyn incompat error Another hir-walker removed from the well-formed queries. This error was always a duplicate of another, but it was able to provide more information because it could invoke `is_dyn_compatible` without worrying about cycle errors. That's also the reason we can't put the error directly into hir_ty_lowering when lowering a `dyn Trait` within an associated item signature. So instead I packed it into the error handling of wf obligation checking.

…ange, r=compiler-errors Add a warning to LateContext::get_def_path Preventing anyone from doing the same error as rust-lang/rust-clippy#15043 fixed

Add DesugaringKind::FormatLiteral Implements `DesugaringKind::FormatLiteral` to mark the FormatArgs desugaring of format literals. The main use for this is to stop yapping about about formatting parameters if we're not anywhere near a format literal. The other use case is to fix suggestions such as rust-lang#141350. It might also be useful for new or existing diagnostics that check whether they're in a format-like macro. cc `@xizheyin` `@fmease`

…aring, r=fee1-dead Clean-up `FnCtxt::is_destruct_assignment_desugaring` I noticed the docstring thing and fixed that; then I thought I'd rewrite the method using let-chains while I'm at it, since that seemed appropriate. But I don't feel too strongly about the second change, so let me know if I should remove it

… r=jdonszelmann Port `#[must_use]` to new attribute parsing infrastructure Ports `must_use` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

…r-errors Don't fail to parse a struct if a semicolon is used to separate fields The first commit is a small refactor.

…chenkov Add a few inline directives in rustc_serialize. I see `debug_strict_add` and `debug_strict_sub` appearing in callgrind output. This bothers me. This PR should make them disappear.

remove few allow(dead_code) Few from serial/parallel compiler leftovers and few from bootstrap.

cranelift: fix target feature name typo: "fxsr" Fix a typo introduced in 71b698c CC: `@clubby789` `@bjorn3`

…t-installation-req, r=GuillaumeGomez Document why tidy checks if `eslint` is installed via `npm` Discussion here: rust-lang#142851

GuillaumeGomez · 2025-06-22T15:35:47Z

@bors r+ p=5 rollup=never

bors · 2025-06-22T15:35:49Z

📌 Commit 8da1a62 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-06-22T17:10:32Z

⌛ Testing commit 8da1a62 with merge 111e9bc...

bors · 2025-06-22T20:08:59Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 111e9bc to master...

rust-timer · 2025-06-22T20:11:49Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#142458	Merge unboxed trait object error suggestion into regular dy…	`eebc3cd84d96ae18a1bfdc5c1c5a3e3af98832a5` (link)
#142593	Add a warning to LateContext::get_def_path	`7bdef4d5746efe2750d80ccd7a543ad2c0b5ad05` (link)
#142594	Add DesugaringKind::FormatLiteral	`cde894e7646d78f2cd681cdc75101fc19d4e97f3` (link)
#142740	Clean-up `FnCtxt::is_destruct_assignment_desugaring`	`e94cd7990d1907c2ea20ab880f41cc16dec9dc78` (link)
#142780	Port `#[must_use]` to new attribute parsing infrastructure	`db86f3f5384d5b866d121ffc7cc59c8f3c37d841` (link)
#142798	Don't fail to parse a struct if a semicolon is used to sepa…	`7e5b36c1726a8148f174dcfa9bc84cf8b54aa6dc` (link)
#142856	Add a few inline directives in rustc_serialize.	`296cd6e8c836bd147ae8941e9c30cb42bcd3ffb2` (link)
#142868	remove few allow(dead_code)	`ca912ecb01866097267cbee874a154d06276b1a0` (link)
#142874	cranelift: fix target feature name typo: "fxsr"	`6d2a34cd38fc46187f9ad9512f317fed8ef53a59` (link)
#142877	Document why tidy checks if `eslint` is installed via `npm`	`37ed9b81dfad19049f030d1f5683a8fefe531804` (link)

previous master: c2ec7532ee

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-22T20:11:58Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c2ec753 (parent) -> 111e9bc (this PR)

Test differences

Show 115 test diffs

Stage 1

session_diagnostics::verify_attr_parsing_empty_confusables_31: pass -> [missing] (J0)
session_diagnostics::verify_attr_parsing_empty_confusables_32: [missing] -> pass (J0)
session_diagnostics::verify_attr_parsing_ill_formed_attribute_input_30: [missing] -> pass (J0)
session_diagnostics::verify_attr_parsing_invalid_alignment_value_32: pass -> [missing] (J0)
session_diagnostics::verify_attr_parsing_invalid_alignment_value_33: [missing] -> pass (J0)
session_diagnostics::verify_attr_parsing_repr_ident_33: pass -> [missing] (J0)
session_diagnostics::verify_attr_parsing_repr_ident_34: [missing] -> pass (J0)
session_diagnostics::verify_attr_parsing_stability_outside_std_30: pass -> [missing] (J0)
session_diagnostics::verify_attr_parsing_stability_outside_std_31: [missing] -> pass (J0)
session_diagnostics::verify_attr_parsing_unrecognized_repr_hint_34: pass -> [missing] (J0)
session_diagnostics::verify_attr_parsing_unrecognized_repr_hint_35: [missing] -> pass (J0)
[ui] tests/ui/attributes/malformed-must_use.rs: [missing] -> pass (J2)
[ui] tests/ui/fmt/non-source-literals.rs: [missing] -> pass (J2)
[ui] tests/ui/rfcs/rfc-2361-dbg-macro/dbg-macro-ref-impl.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/attributes/malformed-must_use.rs: [missing] -> pass (J1)
[ui] tests/ui/fmt/non-source-literals.rs: [missing] -> pass (J1)
[ui] tests/ui/rfcs/rfc-2361-dbg-macro/dbg-macro-ref-impl.rs: [missing] -> pass (J1)

Additionally, 98 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 111e9bc64bbdce14122e3676978f2ceefa5bff1a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 6193.4s -> 4598.5s (-25.8%)
dist-apple-various: 5763.0s -> 7146.6s (24.0%)
x86_64-apple-1: 5895.0s -> 6784.2s (15.1%)
aarch64-apple: 4822.9s -> 4352.8s (-9.7%)
dist-sparcv9-solaris: 4841.6s -> 5188.6s (7.2%)
dist-x86_64-apple: 8744.3s -> 8181.2s (-6.4%)
x86_64-rust-for-linux: 2905.4s -> 3075.6s (5.9%)
x86_64-msvc-ext1: 7137.0s -> 6729.2s (-5.7%)
mingw-check-1: 1883.7s -> 1776.6s (-5.7%)
mingw-check-tidy: 72.4s -> 76.5s (5.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-23T01:59:53Z

Finished benchmarking commit (111e9bc): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.2%]	11
Improvements ✅ (secondary)	-0.5%	[-0.7%, -0.3%]	13
All ❌✅ (primary)	-0.1%	[-0.5%, 1.1%]	12

Max RSS (memory usage)

Results (primary 1.2%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	2.9%	[2.1%, 3.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.2%, -3.8%]	2
All ❌✅ (primary)	1.2%	[1.2%, 1.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	62
Regressions ❌ (secondary)	0.1%	[0.0%, 0.3%]	28
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	62

Bootstrap: 690.174s -> 689.093s (-0.16%)
Artifact size: 371.90 MiB -> 371.98 MiB (0.02%)

oli-obk and others added 23 commits June 13, 2025 13:54

Merge unboxed trait object error suggestion into regular dyn incompat…

1d41c2c

… error

Add a warning to LateContext::get_def_path

6d04085

Factor out seen_comma variable

6809ec1

Recover from semicolon field separator

26a6b55

Add a few inline directives in rustc_serialize.

8e9552a

Implement DesugaringKind::FormatLiteral

b1d1812

Stop dbg! macro yapping about format modifiers

29ce695

remove allow(dead_code) leftovers from serial/parallel compiler

2ddbe39

remove few from bootstrap too

d092dc9

Turn a comment that looks like a docstring into a docstring

fdb76e2

rewrite using let-chains

Port #[must_use] to new attribute parsing infrastructure

b24df42

Signed-off-by: Jonathan Brouwer <[email protected]>

cranelift: fix target feature name type: "fxsr"

75674e2

Document why tidy checks if eslint is installed via npm

90524da

Rollup merge of rust-lang#142593 - blyxyas:improve-docs-itty-bitty-ch…

cab65ef

…ange, r=compiler-errors Add a warning to LateContext::get_def_path Preventing anyone from doing the same error as rust-lang/rust-clippy#15043 fixed

Rollup merge of rust-lang#142780 - JonathanBrouwer:must_use_new_attr,…

2681bb0

… r=jdonszelmann Port `#[must_use]` to new attribute parsing infrastructure Ports `must_use` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

Rollup merge of rust-lang#142798 - camsteffen:recover-semi, r=compile…

194e58c

…r-errors Don't fail to parse a struct if a semicolon is used to separate fields The first commit is a small refactor.

Rollup merge of rust-lang#142856 - cjgillot:inline-serialize, r=petro…

0f89e61

…chenkov Add a few inline directives in rustc_serialize. I see `debug_strict_add` and `debug_strict_sub` appearing in callgrind output. This bothers me. This PR should make them disappear.

Rollup merge of rust-lang#142868 - klensy:dc, r=oli-obk

f1fa46d

remove few allow(dead_code) Few from serial/parallel compiler leftovers and few from bootstrap.

Rollup merge of rust-lang#142874 - marxin:cranelift-typo-fix, r=bjorn3

1474a0f

cranelift: fix target feature name typo: "fxsr" Fix a typo introduced in 71b698c CC: `@clubby789` `@bjorn3`

Rollup merge of rust-lang#142877 - yotamofek:pr/rustdoc/comment-eslin…

8da1a62

…t-installation-req, r=GuillaumeGomez Document why tidy checks if `eslint` is installed via `npm` Discussion here: rust-lang#142851

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 22, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 22, 2025

bors merged commit 111e9bc into rust-lang:master Jun 22, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 22, 2025

GuillaumeGomez deleted the rollup-53dohob branch June 23, 2025 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #142878

Rollup of 10 pull requests #142878

Uh oh!

GuillaumeGomez commented Jun 22, 2025 •

edited by rustbot

Loading

Uh oh!

GuillaumeGomez commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 22, 2025

Uh oh!

github-actions bot commented Jun 22, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 23, 2025

Uh oh!

Uh oh!

Rollup of 10 pull requests #142878

Rollup of 10 pull requests #142878

Uh oh!

Conversation

GuillaumeGomez commented Jun 22, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 22, 2025

Uh oh!

github-actions bot commented Jun 22, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 23, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

GuillaumeGomez commented Jun 22, 2025 •

edited by rustbot

Loading