Add DesugaringKind::FormatLiteral #142594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_ast_lowering/src/format.rs cc @m-ou-se |
|
We might want to block this on #140748, I'm relatively sure. Just FYI |
|
Why is that? |
|
Idk, if it's not conflicting according to git and if it's not stepping on each other's toes in other ways, I guess it's fine — I only skimmed boths diffs. Mara's PR will likely get approved soon anyway. |
xizheyin
reviewed
Jun 17, 2025
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs
Show resolved
Hide resolved
m-ou-se
reviewed
Jun 17, 2025
| @@ -50,6 +50,7 @@ pub struct FormatArgs { | |||
| /// | |||
| /// Generally only useful for lints that care about the raw bytes the user wrote. | |||
| pub uncooked_fmt_str: (LitKind, Symbol), | |||
| pub is_source_literal: bool, | |||
There was a problem hiding this comment.
Can you add a doc comment on this field to explain what it means?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
DesugaringKind::FormatLiteralto mark the FormatArgs desugaring of format literals. The main use for this is to stop yapping about about formatting parameters if we're not anywhere near a format literal. The other use case is to fix suggestions such as #141350. It might also be useful for new or existing diagnostics that check whether they're in a format-like macro.cc @xizheyin @fmease