apply clippy::or_fun_call

[klensy]

Applies https://rust-lang.github.io/rust-clippy/master/index.html?groups=nursery#or_fun_call to reduce needless allocs.

[rustbot]

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

[matthiaskrgr]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 8c83935 with merge 28c89ca...

[nnethercote]

r=me once tests pass and assuming perf comes back neutral (likely, in which case it can be rolled up) or positive.

@bors delegate=klensy

[bors]

✌️ @klensy, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

[bors]

☀️ Try build successful - checks-actions
Build commit: 28c89ca (28c89ca0ba2ef249611acc977eef0f510fbd63dd)

[rust-timer]

Finished benchmarking commit (28c89ca): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.2%	[2.9%, 5.8%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.2%	[2.9%, 5.8%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 756.784s -> 691.076s (-8.68%)
Artifact size: 372.10 MiB -> 372.18 MiB (0.02%)

[nnethercote]

@bors r+

[bors]

📌 Commit 8c83935 has been approved by nnethercote

It is now in the queue for this repository.

[klensy]

@bors rollup=maybe ?