Add spawn APIs for BootstrapCommand to support deferred command execution #142591
+176
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Kobzol
reviewed
Jun 16, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Kobzol
reviewed
Jun 17, 2025
|
Left one comment, after that you can squash and I think we're good to go. The CI failure is a fluke, I think. |
I saw the same error in the last set of push... Need to dig.. |
…tion and update wait_for_output usage
Shourya742
force-pushed
the
2025-06-14-add-spawn-execution-api
branch
from
9675e12 to
55e2c26
Compare
Kobzol
reviewed
Jun 17, 2025
This comment has been minimized.
This comment has been minimized.
Kobzol
reviewed
Jun 17, 2025
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-06-14-add-spawn-execution-api
branch
from
e541562 to
aea3f77
Compare
Shourya742
force-pushed
the
2025-06-14-add-spawn-execution-api
branch
from
aea3f77 to
0512280
Compare
|
Great, thanks! @bors r+ |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new deferred command support in the ExecutionContext and provides APIs to spawn commands and wait for their completion. This structure enables moving away from the start_process helper functions towards a more unified and reusable command execution flow.
r? @Kobzol