correct suggestions in no_std
#13999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
commented
Jan 14, 2025
| @@ -125,7 +125,7 @@ impl LateLintPass<'_> for SingleRangeInVecInit { | |||
| span, | |||
| format!("{suggested_type} of `Range` that is only one element"), | |||
| |diag| { | |||
| if should_emit_every_value { | |||
| if should_emit_every_value && !is_no_std_crate(cx) { | |||
There was a problem hiding this comment.
In a no_std environment, we may use alloc::vec::Vec, but this assumes the existence of a heap allocator, so Clippy shouldn't suggest to use alloc::vec::Vec in general because it violates the purpose of Applicability::MaybeIncorrect. Also, using Applicability::Unspecified is noisy in such environments.
|
Could not assign reviewer from: |
|
r? clippy |
Manishearth
approved these changes
Jan 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…n a `no_std` environment
…o_std` environment
lapla-cogito
force-pushed
the
fixnostd
branch
from
2c04e5b to
3b0b8b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened #13896 before. However, I found that there're more cases where Clippy suggests to use modules that belong to the
stdcrate even in ano_stdenvironment. Therefore, this PR include the changes I've made in #13896 and new changes to fix cases I found this time to prevent wrong suggestions inno_stdenvironments as well.changelog: [
redundant_closure]: correct suggestion inno_stdchangelog: [
repeat_vec_with_capacity]: correct suggestion inno_stdchangelog: [
single_range_in_vec_init]: don't emit suggestion to useVecinno_stdchangelog: [
drain_collect]: correct suggestion inno_stdchangelog: [
map_with_unused_argument_over_ranges]: correct suggestion inno_stdalso close #13895