correct suggestion for redundant_closure lint in a no_std environment
#13896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
commented
Dec 29, 2024
lapla-cogito
force-pushed
the
issue_13895
branch
from
f630370 to
d09013b
Compare
samueltardieu
requested changes
Dec 29, 2024
lapla-cogito
force-pushed
the
issue_13895
branch
from
d09013b to
d36cd2a
Compare
lapla-cogito
force-pushed
the
issue_13895
branch
from
d36cd2a to
4112908
Compare
|
r? clippy |
|
I'm going to close this because I created #13999 which includes the changes in this PR. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
I opened #13896 before. However, I found that there're more cases where Clippy suggests to use modules that belong to the `std` crate even in a `no_std` environment. Therefore, this PR include the changes I've made in #13896 and new changes to fix cases I found this time to prevent wrong suggestions in `no_std` environments as well. changelog: [`redundant_closure`]: correct suggestion in `no_std` changelog: [`repeat_vec_with_capacity`]: correct suggestion in `no_std` changelog: [`single_range_in_vec_init`]: don't emit suggestion to use `Vec` in `no_std` changelog: [`drain_collect`]: correct suggestion in `no_std` changelog: [`map_with_unused_argument_over_ranges`]: correct suggestion in `no_std` also close #13895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
redundant_closure]: correct suggestion in ano_stdenvironmentfix #13895
This PR suggests to use
alloc::vec::Vec::newin ano_stdenvironment.