Skip to content

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Oct 24, 2024

Implement RawStream for &mut impl RawStream, Box<impl RawStream> (and the other required traits) instead of implementing for each &mut T/Box<T> manually.

This includes existing implementations, plus the ones that were missing in certain cases and all future ones, so only new implementations are added.

Split from #221.

@DaniPopes DaniPopes changed the title refactor: Implement RawStream for &mut T generically refactor: Implement RawStream for &mut T and Box<T> generically Oct 24, 2024
@epage epage enabled auto-merge October 24, 2024 15:36
@epage epage merged commit 8a57dcc into rust-cli:main Oct 24, 2024
15 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11502052073

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 52.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/anstyle-wincon/src/ansi.rs 0 1 0.0%
crates/anstyle-wincon/src/stream.rs 0 2 0.0%
crates/anstream/src/stream.rs 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
crates/anstream/src/stream.rs 1 13.16%
Totals Coverage Status
Change from base Build 11282311767: 0.2%
Covered Lines: 1221
Relevant Lines: 2341

💛 - Coveralls

@DaniPopes DaniPopes deleted the raw-stream-refmut branch October 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants