-
Notifications
You must be signed in to change notification settings - Fork 33
feat: Implement RawStream for more types #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3fcc234
to
d59730c
Compare
This is doing a lot at once and is making it harder to track what is or isn't a breakin change (or even what all is changing. Could you split this up into more commits? |
Pull Request Test Coverage Report for Build 11499301620Details
💛 - Coveralls |
d59730c
to
2bcab4d
Compare
2bcab4d
to
8ad5ee7
Compare
It should be better now, can you check again? The main diff is that all the manual |
I don't see this having been changed from doing multiple things. e.g. this has new inlining, switching from |
Might be fastest to focus on the impls you need and splitting out clean up into their own Prs. |
OK, I'll split this into more PRs. |
Thanks! That made it much easier to look through |
Closes #220.
Implements
RawStream
(and the other required traits) for&mut impl RawStream
,Box<impl RawStream>
,dyn std::io::Write {,+ Send {,+ Sync}}
.