Skip to content

Conversation

DaniPopes
Copy link
Contributor

Closes #220.

Implements RawStream (and the other required traits) for &mut impl RawStream, Box<impl RawStream>, dyn std::io::Write {,+ Send {,+ Sync}}.

@epage
Copy link
Collaborator

epage commented Oct 24, 2024

This is doing a lot at once and is making it harder to track what is or isn't a breakin change (or even what all is changing.

Could you split this up into more commits?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11499301620

Details

  • 2 of 15 (13.33%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.6%) to 52.516%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/anstyle-wincon/src/ansi.rs 0 1 0.0%
crates/anstyle-wincon/src/stream.rs 0 4 0.0%
crates/anstream/src/stream.rs 2 10 20.0%
Files with Coverage Reduction New Missed Lines %
crates/anstyle-wincon/src/stream.rs 2 0.0%
crates/anstream/src/stream.rs 2 19.23%
Totals Coverage Status
Change from base Build 11282311767: 0.6%
Covered Lines: 1221
Relevant Lines: 2325

💛 - Coveralls

@DaniPopes
Copy link
Contributor Author

DaniPopes commented Oct 24, 2024

It should be better now, can you check again? The main diff is that all the manual &mut _ and Box<_> implementations are removed for the generic ones.
The diff for RawStream is the same for the other traits.

@epage
Copy link
Collaborator

epage commented Oct 24, 2024

I don't see this having been changed from doing multiple things. e.g. this has new inlining, switching from &<trait> to &T blanket impls, etc.

@epage
Copy link
Collaborator

epage commented Oct 24, 2024

Might be fastest to focus on the impls you need and splitting out clean up into their own Prs.

@DaniPopes
Copy link
Contributor Author

OK, I'll split this into more PRs.

@epage
Copy link
Collaborator

epage commented Oct 24, 2024

Thanks! That made it much easier to look through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using anstream with tracing_appender's RollingFileAppender
3 participants