Skip hole detection on broken ZFS filesystems #4002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #3717, ZFS has known bugs around SEEK_HOLE/SEEK_DATA causing it to indicate spurious holes. We detect the case where it (inconsistently) ends up indicating the hole to be zero sized, but depending on the sequencing of events, the related upstream issues indicate that the file system could indicate a non-zero-sized spurious hole on these versions. To avoid trace corruption on such file systems, we must skip our SEEK_HOLE/SEEK_DATA optimizations.
Keno
changed the title
Keno
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Aug 9, 2025
Carries rr-debugger/rr#4002 ref JuliaLang/julia#55130
Keno
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Aug 11, 2025
|
Thanks!!! Sorry about the delay. What a hideous bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3717, ZFS has known bugs around SEEK_HOLE/SEEK_DATA causing it to indicate spurious holes. We detect the case where it (inconsistently) ends up indicating the hole to be zero sized, but depending on the sequencing of events, the related upstream issues indicate that the file system could indicate a non-zero-sized spurious hole on these versions. To avoid trace corruption on such file systems, we must skip our SEEK_HOLE/SEEK_DATA optimizations.