Remove duplicate typedefs #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ted Miller <[email protected]>
Contributor
Author
|
I followed these instructions to add the 'signed off by' field.
|
Member
|
LGTM, please @JanStaschulat merge if you are ok |
Member
|
@mergify backport foxy galactic |
Contributor
🟠 Waiting for conditions to matchDetails
Hey, I reacted but my real name is @Mergifyio |
pablogs9
approved these changes
Feb 23, 2022
JanStaschulat
approved these changes
Feb 23, 2022
Contributor
JanStaschulat
left a comment
JanStaschulat
left a comment
There was a problem hiding this comment.
Interesting that there are duplicates. Thanks for your PR.
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2022
Signed-off-by: Ted Miller <[email protected]> (cherry picked from commit 2381ec5)
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2022
Signed-off-by: Ted Miller <[email protected]> (cherry picked from commit 2381ec5)
Contributor
✅ Backports have been createdDetails
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three typedefs that got duplicated in executor_handle.h. It looks like a copy/paste accident.
I'm using a really old compiler, and it generates an error for the redefinition. I'm guessing it's not an error with modern compilers, but it's still nice to remove unnecessary stuff from the header.