Skip to content

Conversation

@david-wb
Copy link
Contributor

@david-wb david-wb commented Jan 30, 2025

Note: It's my first time trying to release a ros2 package. Apologies in advance for any mistakes on my part. I am following these instructions.

Please Add This Package to be indexed in the rosdistro.

humble
jazzy
rolling

The source is here:

https://github.com/namo-robotics/aruco_markers

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution labels Jan 30, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@mjcarroll mjcarroll added the held for sync Issue/PR has been held because the distribution is in a sync hold label Feb 3, 2025
@mjcarroll
Copy link
Member

Holding for Rolling sync

@audrow audrow removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Feb 14, 2025
@marcoag
Copy link
Contributor

marcoag commented Feb 20, 2025

@david-wb can you point out differences (if any) between aruco_ros, aruco_opencv and the one proposed here?

@david-wb
Copy link
Contributor Author

david-wb commented Feb 20, 2025

@marcoag aruco_ros is out-of-date and unmaintained, and was not working with the gazebo camera sensor, so I created this new version which has the following properties:

  • Clear and simple API with full examples in the README
  • Supports selecting the arcuco dictionary to use
  • Works with gazebo camera sensor

I'm not familiar with aruco_opencv but it seems to have similar limitations as aruco_ros, at least for my use case.

@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Mar 4, 2025
@sloretz
Copy link
Contributor

sloretz commented Mar 4, 2025

Holding for Rolling sync

@github-actions
Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Mar 19, 2025
@christophebedard christophebedard removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Mar 26, 2025
@christophebedard
Copy link
Member

christophebedard commented Mar 26, 2025

New package checklist:

@marcoag are you satisfied with the explanation above? #44321 (comment)

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Mar 27, 2025
@david-wb david-wb requested a review from Yadunund as a code owner March 31, 2025 12:28
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@david-wb
Copy link
Contributor Author

@christophebedard I haved renamed the project from aruco_ros2 to aruco_markers. Does this help complete the new package checklist above?

@christophebedard
Copy link
Member

Yeah, I think that's fine.

Could you re-order your entries alphabetically? See the failing CI job.

@david-wb david-wb changed the title Adding aruco_ros2 to index for distro Adding aruco_markers to index for distro Apr 1, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@christophebedard christophebedard merged commit 7bfbde3 into ros:master Apr 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants