Improved implementation of handleAction - Take 2

[yangmillstheory]

This is based off of the ideas in #97, which generated a lot of good discussion. Roughly:

• don't mutate the passed in reducers
• use small lodash libraries
• properly scope reducer setup (i.e. do it once, and not every time an action is handled)

Full credit goes to @Lucretiel; just submitting it here for a cleaner pull request.

@Lucretiel, please review as well.

[yangmillstheory]

This works with string action types and action creators. I think calling out isSymbol explicitly clarifies the special case (where we cannot call .toString()).

[timche]

👍

[yangmillstheory]

ping @timche for the new dependencies and that general approach
ping @Lucretiel

This is a small PR (from the long-outstanding #97) so, I'm planning to get merge sometime over the weekend. If there's no time to review, we can review retrospectively and I can address those comments after merge.

[timche]

=== true could be omitted.

[yangmillstheory]

What are your thoughts on #97 (comment)?

[timche]

You are right, sorry, error could be any other value than true. === true adds more safety to respect FSA.

[yangmillstheory]

No problem! I thought the same thing when reviewing #97; thanks to @Lucretiel for doing the research and pointing it out.

[timche]

After clarified all the things, this PR is very neat 👌🏻. You get my check mark after you have resolved the linting issues 😁

@Lucretiel are you also fine with that?

[yangmillstheory]

Thanks, and big thanks to @Lucretiel (this is really his PR).

There's a build break with b5546b5

/Users/VictorAlvarez/code/private/redux-actions/src/handleAction.js (3/0)
  ✖  1:24  Unable to resolve path to module 'lodash/isfunction'  import/no-unresolved
  ✖  3:19  Unable to resolve path to module 'lodash/isnil'       import/no-unresolved
  ✖  4:22  Unable to resolve path to module 'lodash/issymbol'    import/no-unresolved

I'll see what I can do to fix it; let me know if you have any ideas on it.

[yangmillstheory]

9a317f3 fixed the build. The interesting lesson was that the environments the tests were run in had a case-insensitive filesystem, including mine:

$ touch abc1
$ touch abC1
$ ls -l ab*
-rw-r--r--  1 VictorAlvarez  staff  0 Jul 16 02:05 abc1

but for some reason eslint-plugin-import wasn't picking this up.

[yangmillstheory]

@timche what do you think of releasing this in v0.10.2?

[timche]

I would make this part of v0.11.0 with a bunch of other non-breaking PRs. Should try to follow semver.

[yangmillstheory]

Squashed merged in 5e78f25.

Would you consider this addition a bug fix or new functionality?

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.
Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.