simplify handleActions (#109)

Author: yangmillstheory

README.md

@@ -93,6 +93,8 @@ handleAction('FETCH_DATA', {
 });
 ```
 
+If either `next()` or `throw()` are `undefined` or `null`, then the identity function is used for that reducer.
+
 The optional third parameter specifies a default or initial state, which is used when `undefined` is passed to the reducer.
 
 ### `handleActions(reducerMap, ?defaultState)`

package.json

@@ -48,6 +48,7 @@
     "rimraf": "^2.5.3"
   },
   "dependencies": {
+    "lodash": "^4.13.1",
     "reduce-reducers": "^0.1.0"
   }
 }

src/createAction.js

@@ -1,6 +1,4 @@
-function identity(t) {
-  return t;
-}
+import identity from 'lodash/identity';
 
 export default function createAction(type, payloadCreator, metaCreator) {
   const finalPayloadCreator = typeof payloadCreator === 'function'

src/handleAction.js

@@ -1,28 +1,22 @@
-function isFunction(val) {
-  return typeof val === 'function';
-}
+import isFunction from 'lodash/isFunction';
+import identity from 'lodash/identity';
+import isNil from 'lodash/isNil';
+import isSymbol from 'lodash/isSymbol';
 
 export default function handleAction(type, reducers, defaultState) {
-  const typeValue = isFunction(type)
-    ? type.toString()
-    : type;
-
-  return (state = defaultState, action) => {
-    // If action type does not match, return previous state
-    if (action.type !== typeValue) return state;
+  const typeValue = isSymbol(type)
+    ? type
+    : type.toString();
 
-    const handlerKey = action.error === true ? 'throw' : 'next';
+  const [nextReducer, throwReducer] = isFunction(reducers)
+    ? [reducers, reducers]
+    : [reducers.next, reducers.throw].map(reducer => (isNil(reducer) ? identity : reducer));
 
-    // If function is passed instead of map, use as reducer
-    if (isFunction(reducers)) {
-      reducers.next = reducers.throw = reducers;
+  return (state = defaultState, action) => {
+    if (action.type !== typeValue) {
+      return state;
     }
 
-    // Otherwise, assume an action map was passed
-    const reducer = reducers[handlerKey];
-
-    return isFunction(reducer)
-      ? reducer(state, action)
-      : state;
+    return (action.error === true ? throwReducer : nextReducer)(state, action);
   };
 }