Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Tweak golangci-lint to avoid out-of-memory in Github Actions #1198

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Aug 9, 2022

Signed-off-by: Pavel Macík [email protected]

Changes

This PR:

  • Updates golangci-lint to latest version
  • Splits execution of individual Go linters
  • Fixes new issues found by the newer versions of the linters

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the ci CI related issues label Aug 9, 2022
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1198 (137b78b) into master (715859c) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
- Coverage   58.08%   58.02%   -0.06%     
==========================================
  Files          33       33              
  Lines        2839     2835       -4     
==========================================
- Hits         1649     1645       -4     
  Misses       1029     1029              
  Partials      161      161              
Impacted Files Coverage Δ
pkg/reconcile/pipeline/context/impl.go 66.07% <100.00%> (-0.18%) ⬇️
...kg/reconcile/pipeline/context/spec_binding_impl.go 68.96% <100.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715859c...137b78b. Read the comment docs.

@pmacik pmacik force-pushed the golangci-lint-gha branch from 7956686 to e88cc3f Compare August 9, 2022 14:31
@pmacik pmacik changed the title Lower the concurrency for golangci-lint to avoid being killed out-of-memory in Github Actions WIP: Lower the concurrency for golangci-lint to avoid being killed out-of-memory in Github Actions Aug 9, 2022
@pmacik pmacik force-pushed the golangci-lint-gha branch 3 times, most recently from ef015aa to 8c96e54 Compare August 9, 2022 14:50
@pmacik pmacik changed the title WIP: Lower the concurrency for golangci-lint to avoid being killed out-of-memory in Github Actions WIP: Tweak golangci-lint to avoid out-of-memory in Github Actions Aug 9, 2022
@pmacik pmacik force-pushed the golangci-lint-gha branch from 8c96e54 to 315b56f Compare August 9, 2022 14:59
@github-actions github-actions bot removed the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Aug 9, 2022
@pmacik pmacik force-pushed the golangci-lint-gha branch from 315b56f to 137b78b Compare August 9, 2022 15:09
@pmacik pmacik changed the title WIP: Tweak golangci-lint to avoid out-of-memory in Github Actions Tweak golangci-lint to avoid out-of-memory in Github Actions Aug 9, 2022
Copy link
Contributor

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0bbbfbf into redhat-developer:master Aug 9, 2022
@pmacik pmacik deleted the golangci-lint-gha branch August 12, 2022 15:00
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved ci CI related issues lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants