WIP: Tweak golangci-lint to avoid out-of-memory in Github Actions

Signed-off-by: Pavel Macík <[email protected]>

Author: pmacik

make/lint.mk

@@ -11,15 +11,26 @@ lint-yaml: ${YAML_FILES}
 	$(Q)$(PYTHON_VENV_DIR)/bin/pip install yamllint==1.23.0
 	$(Q)$(PYTHON_VENV_DIR)/bin/yamllint -c .yamllint $(YAML_FILES)
 
+GO_LINT_CMD = $(Q)GOFLAGS="$(GOFLAGS)" GOGC=30 GOCACHE=$(GOCACHE) $(OUTPUT_DIR)/golangci-lint ${V_FLAG} run --concurrency=1 --verbose --deadline=30m --disable-all --enable
+
 .PHONY: lint-go-code
 ## Checks GO code
 lint-go-code: $(GOLANGCI_LINT_BIN) fmt vet
 	# This is required for OpenShift CI enviroment
 	# Ref: https://github.com/openshift/release/pull/3438#issuecomment-482053250
-	$(Q)GOFLAGS="$(GOFLAGS)" GOCACHE="$(GOCACHE)" $(OUTPUT_DIR)/golangci-lint ${V_FLAG} run --deadline=30m
+	$(GO_LINT_CMD) deadcode
+	$(GO_LINT_CMD) errcheck
+	$(GO_LINT_CMD) govet
+	$(GO_LINT_CMD) ineffassign
+	$(GO_LINT_CMD) staticcheck
+	$(GO_LINT_CMD) structcheck
+	$(GO_LINT_CMD) typecheck
+	$(GO_LINT_CMD) unused
+	$(GO_LINT_CMD) varcheck
+	$(GO_LINT_CMD) gosimple
 
 $(GOLANGCI_LINT_BIN):
-	$(Q)curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./out v1.45.2
+	$(Q)curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./out v1.48.0
 
 .PHONY: lint-python-code
 ## Check the python code

pkg/client/kubernetes/whoami.go

@@ -3,14 +3,14 @@ package kubernetes
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
 	authenticationapi "k8s.io/api/authentication/v1"
 	authorizationv1 "k8s.io/api/authorization/v1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/rest"
 	"net/http"
+	"os"
 	"regexp"
 	"strings"
 )
@@ -55,7 +55,7 @@ func WhoAmI(config *rest.Config) (string, error) {
 	// from vendor/k8s.io/client-go/transport/round_trippers.go:HTTPWrappersForConfig function, tokenauth has preference over basicauth
 	if transportConfig.HasTokenAuth() {
 		if config.BearerTokenFile != "" {
-			d, err := ioutil.ReadFile(config.BearerTokenFile)
+			d, err := os.ReadFile(config.BearerTokenFile)
 			if err != nil {
 				return "", err
 			}