This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Fix CI #1127
Merged
Fix CI #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
sadlerap
force-pushed
the
controller-gen-downgrade
branch
from
81f9661 to
9c553eb
Compare
sadlerap
force-pushed
the
controller-gen-downgrade
branch
3 times, most recently
from
eb74d76 to
85a507b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1127 +/- ##
=======================================
Coverage 58.92% 58.92%
=======================================
Files 30 30
Lines 1670 1670
=======================================
Hits 984 984
Misses 560 560
Partials 126 126
Continue to review full report at Codecov.
|
sadlerap
force-pushed
the
controller-gen-downgrade
branch
4 times, most recently
from
0437e84 to
414b842
Compare
|
/retest |
In commit ea79796 ("update to operator-sdk 1.3.0 (redhat-developer#848)"), we upgraded controller-gen to 0.8.0. However, v0.8.0 requires go 1.17 or greater, which is currently unavailable in Red Hat's container registries (i.e. there's no container on catalog.redhat.com); consequently, SBO is built with go 1.16. Until that is rectified, downgrade controller-gen to 0.7.0, which builds with go 1.16. At the same time, use `go install` instead of the deprecated `go get` when we install local build tools, such as controller-gen, yq, and kustomize. This requires a version bump of kustomize to work correctly as well as adding an extra step to install a recent version of go in the non-OLM github actions acceptance test runner. Finally, with the release of go 1.18, our go linting needs to become aware of this new release, since our linting runs with the latest release of go. This can be fixed by updating the golangci/golangci-lint runner to v1.45.2; since v1.45.1, it will autodetect the language version of a project. Signed-off-by: Andy Sadler <[email protected]>
sadlerap
force-pushed
the
controller-gen-downgrade
branch
from
414b842 to
11a8837
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind bug
In commit ea79796 ("update to operator-sdk 1.3.0 (#848)"), we upgraded controller-gen to 0.8.0. However, v0.8.0 requires go 1.17 or greater, which is currently unavailable in Red Hat's container registries (i.e. there's no container on catalog.redhat.com); consequently, SBO is built with go 1.16. Until that is rectified, downgrade controller-gen to 0.7.0, which builds with go 1.16.
At the same time, use
go installinstead of the deprecatedgo getwhen we install local build tools, such as controller-gen, yq, and kustomize. This requires a version bump of kustomize to work correctly as well as adding an extra step to install a recent version of go in the non-OLM github actions acceptance test runner.Finally, with the release of go 1.18, our go linting needs to become aware of this new release, since our linting runs with the latest release of go. This can be fixed by updating the golangci/golangci-lint runner to v1.45.2; since v1.45.1, it will autodetect the language version of a project.
Signed-off-by: Andy Sadler [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.