Downgrade controller-gen to v0.7.0

In commit ea79796 ("update to operator-sdk 1.3.0 (#848)"), we upgraded
controller-gen to 0.8.0.  However, v0.8.0 requires go 1.17 or greater,
which is currently unavailable in Red Hat's container registries (i.e.
there's no container on catalog.redhat.com); consequently, SBO is built
with go 1.16.  Until that is rectified, downgrade controller-gen to
0.7.0, which builds with go 1.16.

At the same time, we should be using `go install` instead of the now
deprecated `go get` when we install tools.  There are still a few tools
that require `go get`, but for those that don't, we should use the new
installation method.  This requires a version bump of kustomize to work.

Signed-off-by: Andy Sadler <[email protected]>

Author: sadlerap

hack/common.mk

@@ -88,37 +88,37 @@ gen-mocks: mockgen
 # Download controller-gen locally if necessary
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 controller-gen:
-	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0)
+	$(call go-install-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.7.0)
 
 # Download kustomize locally if necessary
 KUSTOMIZE = $(shell pwd)/bin/kustomize
 kustomize:
-	$(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/[email protected])
+	$(call go-install-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/[email protected])
 
-# go-get-tool will 'go get' any package $2 and install it to $1.
-define go-get-tool
+# go-install-tool will 'go install' any package $2 and install it to $1.
+define go-install-tool
 @[ -f $(1) ] || { \
 set -e ;\
 TMP_DIR=$$(mktemp -d) ;\
 cd $$TMP_DIR ;\
 go mod init tmp ;\
 echo "Downloading $(2)" ;\
-GOBIN=$(PROJECT_DIR)/bin go get $(2) ;\
+GOBIN=$(PROJECT_DIR)/bin go install $(2) ;\
 rm -rf $$TMP_DIR ;\
 }
 endef
 
 YQ = $(shell pwd)/bin/yq
 yq:
-	$(call go-get-tool,$(YQ),github.com/mikefarah/yq/[email protected])
+	$(call go-install-tool,$(YQ),github.com/mikefarah/yq/[email protected])
 
 KUBECTL_SLICE = $(shell pwd)/bin/kubectl-slice
 kubectl-slice:
-	$(call go-get-tool,$(KUBECTL_SLICE),github.com/patrickdappollonio/[email protected])
+	$(call go-install-tool,$(KUBECTL_SLICE),github.com/patrickdappollonio/[email protected])
 
 MOCKGEN = $(shell pwd)/bin/mockgen
 mockgen:
-	$(call go-get-tool,$(MOCKGEN),github.com/golang/mock/[email protected])
+	$(call go-install-tool,$(MOCKGEN),github.com/golang/mock/[email protected])
 
 .PHONY: opm
 OPM =  $(shell pwd)/bin/opm
@@ -136,4 +136,4 @@ OPM = $(shell which opm)
 endif
 endif
 
-all: build
+all: build