Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Sep 10, 2025

Update README contents.

@bdice bdice requested a review from a team as a code owner September 10, 2025 18:23
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Agree with all the choices that were made here.

@jameslamb jameslamb added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change and removed non-breaking Introduces a non-breaking change labels Sep 10, 2025
@jameslamb jameslamb requested a review from a team as a code owner September 10, 2025 19:08
@jameslamb jameslamb requested a review from gforsyth September 10, 2025 19:08
@jameslamb jameslamb removed the request for review from gforsyth September 10, 2025 19:09
@jameslamb
Copy link
Member

devcontainer CI jobs are failing with stuff like this:

[2025-09-10T19:15:51.061Z] postAttachCommand from Feature './features/src/utils' failed with exit code 1. Skipping any further user-provided commands.

Error: Command failed: /bin/bash -li +o history devcontainer-utils-post-attach-command
at E (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:235:157)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async Promise.allSettled (index 0)
at async b9 (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:237:119)
at async ND (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:226:4668)
at async N9 (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:226:4475)
at async MD (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:226:3460)
at async Zg (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:226:2623)
at async m6 (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:467:1526)
at async ax (/home/runner/_work/_tool/node/22.19.0/x64/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:467:960)

(devcontainer build link)

That's fine, and expected. The RAPIDs devcontainers rely on repository names to dispatch to commands, and there's not any configuration for a repo called cumlprims_mg-public there: https://github.com/rapidsai/devcontainers/blob/20d75fd9edc983d88c12271ac111c420518e562a/features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml#L175

That'll be fixed when the repo is renamed.

Admin-merging this.

@jameslamb
Copy link
Member

/merge

@jameslamb jameslamb merged commit e65125e into rapidsai:branch-25.10 Sep 10, 2025
12 of 16 checks passed
@jameslamb
Copy link
Member

I'd hoped /merge would work because we have the ops-bot enabled here and the branch protection didn't yet require all jobs to pass... will look into fixing that in a bit.

@jameslamb jameslamb mentioned this pull request Sep 10, 2025
AyodeAwe added a commit that referenced this pull request Oct 8, 2025
* DOC v25.10 Updates [skip ci]

* merge pull request 275 from rapidsai/branch-25.08

* Allow latest OS in devcontainers (#276)

This PR removes the OS suffix from devcontainers, allowing the upstream devcontainer images to determine the OS version.

Contributes to rapidsai/build-planning#200.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: https://github.com/rapidsai/cumlprims_mg/pull/276

* Use GCC 14 in conda builds. (#265)

conda-forge is migrating to gcc 14, so this PR is updating for alignment.

See rapidsai/build-planning#188

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)

URL: https://github.com/rapidsai/cumlprims_mg/pull/265

* Update build infra to support new branching strategy (#273)

rapids_config will use `RAPIDS_BRANCH` contents to determine what branch to use

Authors:
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/273

* RAPIDS dependency now use the new rapids-cmake branch info (#278)

This is required to handle when we switch RAPIDS branching strategy

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/278

* Use rapids_cuda_enable_fatbin_compression (#280)

Standardize compression flags via rapids_cuda_enable_fatbin_compression

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/280

* Use build cluster in devcontainers (#281)

RAPIDS has deployed an autoscaling cloud build cluster that can be used to accelerate building large RAPIDS projects. This contributes to rapidsai/build-planning#209.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/281

* Build and test with CUDA 13.0.0 (#282)

Contributes to rapidsai/build-planning#208

* uses CUDA 13.0.0 to build and test
* adds CUDA 13 devcontainers

Contributes to rapidsai/build-planning#68

* updates to CUDA 13 dependencies in fallback entries in `dependencies.yaml` matrices (i.e., the ones that get written to `pyproject.toml` in source control)

## Notes for Reviewers

This switches GitHub Actions workflows to the `cuda13.0` branch from here: rapidsai/shared-workflows#413

A future round of PRs will revert that back to `branch-25.10`, once all of RAPIDS supports CUDA 13.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: https://github.com/rapidsai/cumlprims_mg/pull/282

* Update rapids-dependency-file-generator (#283)

This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: https://github.com/rapidsai/cumlprims_mg/pull/283

* Open Source license and headers

* open source prep: docs and copyright updates

* Update README (#2)

* Update README

* fix branch references

---------

Co-authored-by: James Lamb <[email protected]>

* update pre-commit hooks (#3)

Updates all pre-commit hooks with `pre-commit autoupdate`.

## Notes for Reviewers

Using this to test CI.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #3

* hide RAFT #pragma deprecation warnings (#4)

* hide RAFT #pragma deprecation warnings

* add -DDISABLE_DEPRECATION_WARNING=ON

* rename DISABLE_DEPRECATION_WARNING -> DISABLE_DEPRECATION_WARNINGS

* Fix typos and improve clarity in README.md (#6)

- Fix "muti-node" → "multi-node" typo
- Add missing colon after "conda" in bullet point
- Capitalize "GitHub" properly
- Fix "succesfully" → "successfully" typo
- Fix broken link reference to custom build options section

Authors:
  - Simon Adorf (https://github.com/csadorf)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #6

* configuring repo for automatic release notes generation (#7)

* Empty commit to trigger a build (#10)

* Fix missed deps in update-version.sh (#13)

---------

Co-authored-by: gpuCI <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Robert Maynard <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Dante Gama Dessavre <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: Simon Adorf <[email protected]>
Co-authored-by: Mike Sarahan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants