Skip to content

Disable tests requiring JFR events on Semeru #51282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brunobat wants to merge 1 commit into from
+6 −0
Closed

Disable tests requiring JFR events on Semeru #51282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../deployment/src/test/java/io/quarkus/opentelemetry/deployment/metrics/JvmMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import java.util.Set;
import java.util.stream.Collectors;

import io.quarkus.test.DisabledOnSemeru;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.core.Response;
Expand All @@ -31,6 +32,7 @@
/**
* Validate all JVM metrics being produced.
*/
@DisabledOnSemeru(reason = "JFR is not supported on Semeru yet")
Copy link
Member

@gsmet gsmet Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't understand what's going on because I had them passing. See JdkUtil.isSemeru() call below. Did we add some metrics recently?

Copy link
Member Author

@brunobat brunobat Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no new JVM metrics.

Copy link
Member

@gsmet gsmet Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's try another approach first: #51296 .

I will close this one but please don't drop the branch as we might reconsider this decision if ^ is not enough.

public class JvmMetricsTest extends BaseJvmMetricsTest {
@RegisterExtension
static final QuarkusUnitTest TEST = new QuarkusUnitTest()
Expand Down
2 changes: 2 additions & 0 deletions integration-tests/opentelemetry/src/test/java/io/quarkus/it/opentelemetry/MetricsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@

import java.util.Set;

import io.quarkus.test.junit.DisabledOnSemeru;
import io.quarkus.test.junit.QuarkusIntegrationTest;

@QuarkusIntegrationTest
@DisabledOnSemeru(reason = "JFR is not supported on Semeru yet")
public class MetricsIT extends MetricsTest {

@Override
Expand Down
2 changes: 2 additions & 0 deletions integration-tests/opentelemetry/src/test/java/io/quarkus/it/opentelemetry/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.util.Set;
import java.util.stream.Collectors;

import io.quarkus.test.junit.DisabledOnSemeru;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand All @@ -25,6 +26,7 @@
import io.restassured.common.mapper.TypeRef;

@QuarkusTest
@DisabledOnSemeru(reason = "JFR is not supported on Semeru yet")
public class MetricsTest {
@BeforeEach
@AfterEach
Expand Down
Loading