-
Notifications
You must be signed in to change notification settings - Fork 3k
Disable tests requiring JFR events on Semeru #51282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
|
/cc @radcortez (opentelemetry) |
|
@gsmet not sure if the annotation will work on the IT tests... |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ❌ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ Initial JDK 17 Build #
- Failing: extensions/opentelemetry/deployment
! Skipped: devtools/bom-descriptor-json docs extensions/liquibase/liquibase-mongodb/deployment and 72 more📦 extensions/opentelemetry/deployment
❌ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.12.0:check (check-imports) on project quarkus-opentelemetry-deployment: Imports are not sorted in /home/runner/_work/quarkus/quarkus/extensions/opentelemetry/deployment/src/test/java/io/quarkus/opentelemetry/deployment/metrics/JvmMetricsTest.java
| /** | ||
| * Validate all JVM metrics being produced. | ||
| */ | ||
| @DisabledOnSemeru(reason = "JFR is not supported on Semeru yet") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I don't understand what's going on because I had them passing. See JdkUtil.isSemeru() call below. Did we add some metrics recently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no new JVM metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's try another approach first: #51296 .
I will close this one but please don't drop the branch as we might reconsider this decision if ^ is not enough.
No description provided.