Refactoring: Pull out resolving of configuration files #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The build error is unrelated. @majguo could you please take a look at the logs? |
albers
force-pushed
the
config-file-resolver
branch
from
0216a5b to
ab942f1
Compare
Contributor
Author
|
I'm thinking of including this change set in my PR for migration to the new dev services api. |
Contributor
Author
|
@majguo Can you please take a look at the CI errors? I get the same errors when running the tests locally. |
Contributor
Author
|
Closing in favor of #466. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring pulls out code used for locating Azure Service Bus emulator configuration files from the Dev Services processor and the config interfaces into a dedicated class.
The new class has tests that illustrate and verify the rules for resolving the configuration file: the role of the default configuration file location and the fallback configuration.
I wanted to slim down the dev services processor so that the upcoming migration to the new dev services api (proposal, issue, blog) will be easier to implement and review.