Update typing to fix errors [skip netlify] #3414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module: metrics
Collaborator
Author
|
Failures with nightly seem unrelated. This is good to go @vfdev-5 :) |
goanpeca
changed the title
auto-merge was automatically disabled
June 11, 2025 21:57
Pull request was closed
pytorch-bot
bot
dismissed
vfdev-5’s stale review
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update typing to fix errors and also now run typing checks on latest torch, not only on nightly.