-
-
Notifications
You must be signed in to change notification settings - Fork 657
Update to use pyproject.toml only #3413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
789176b to
601ed5e
Compare
|
We may need to change here the conditions when unit tests are triggered: ignite/.github/workflows/unit-tests.yml Lines 7 to 23 in adbb260
|
3a47ded to
add9c54
Compare
|
@vfdev-5 could we change the netlify command to use so we can check this PR runs ok?
Besides the nigthly builds, which seem to be unrelated to this PR and related to precision differences, this one is ready for review. |
efc806d to
d9fc9c6
Compare
321c3e9 to
4087972
Compare
b0ed4b5 to
b29b972
Compare
b29b972 to
1a23abb
Compare
4d1dcbe to
96de3ac
Compare
96de3ac to
7873405
Compare
|
I know setuptools was more convenient with respect to the conda build meta yaml, cause we could load the setup.py data. Conda build should provide something similar for pyproject.toml but it does not 🤦🏼 . I could create a small pre-commit local hook so that we make sure the I tested the rest of the conda and pypi package creation locally step by step, to make sure all was working as expected. |
| @@ -1,27 +1,29 @@ | |||
| {% set data = load_setup_py_data() %} | |||
| {% set __version__ = "0.6.0" %} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I understand now what you were talking about when saying that conda recipe stuff support less pyproject. Can we write some bash or python script in this field {% set variable = script() %} to fetch the version from __init__.py ?
Maybe, we can provide this in a follow-up PR.
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR, Gonzalo!
Let's land it and see how it works
Remove the use of
setup.pyand migrate all topyproject.tomland hatch.The source of truth for the version of the package remains on
ignite/__init__.py.Depends on: