Skip to content

Categorizing IterDataPipes #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Feb 11, 2022

Stack from ghstack:

Categorizing IterDataPipes into more specific categories. Still need to add category descriptions.

Differential Revision: D34221378

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 11, 2022
NivekT added a commit that referenced this pull request Feb 11, 2022
ghstack-source-id: 62ade43
Pull Request resolved: #219
@NivekT NivekT marked this pull request as draft February 11, 2022 22:02
Categorizing IterDataPipes into more specific categories. Still need to add category descriptions.

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Feb 14, 2022
ghstack-source-id: da701da
Pull Request resolved: #219
@NivekT NivekT marked this pull request as ready for review February 14, 2022 20:45
@NivekT NivekT requested a review from ejguan February 14, 2022 20:45
@NivekT NivekT mentioned this pull request Feb 14, 2022
15 tasks
@NivekT
Copy link
Contributor Author

NivekT commented Feb 14, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to re-order the sub-directory of torchdat.datapipes.iter to reflect these changes?
Besides, how about the map?

@VitalyFedyunin
Copy link
Contributor

Please do not reorder, as part of this PR. We don't want to introduce such changes right before release.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/52/head branch February 20, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants