Skip to content

Adding TorchData tutorial #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Feb 10, 2022

Stack from ghstack:

Adding a basic tutorial for TorchData

Differential Revision: D34144164

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2022
NivekT added a commit that referenced this pull request Feb 10, 2022
ghstack-source-id: 08f28df
Pull Request resolved: #212
@NivekT
Copy link
Contributor Author

NivekT commented Feb 10, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT NivekT changed the title Adding tutorial Adding TorchData tutorial Feb 10, 2022
@NivekT NivekT marked this pull request as draft February 10, 2022 15:58
NivekT added a commit that referenced this pull request Feb 10, 2022
ghstack-source-id: dcdfc68
Pull Request resolved: #212
NivekT added a commit that referenced this pull request Feb 10, 2022
ghstack-source-id: 0ec0739
Pull Request resolved: #212
@NivekT
Copy link
Contributor Author

NivekT commented Feb 10, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT NivekT marked this pull request as ready for review February 10, 2022 22:37
Adding a basic tutorial for TorchData

Differential Revision: [D34144164](https://our.internmc.facebook.com/intern/diff/D34144164)

[ghstack-poisoned]
@NivekT
Copy link
Contributor Author

NivekT commented Feb 14, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


```py
@functional_datapipe("parse_csv_files")
@functional_datapipe("parse_csv")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could break TorchText datasets, can you please verify with them

Copy link
Contributor Author

@NivekT NivekT Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functional API was changed a long time ago, it is the README file that didn't get updated.

The change here updates the README file, not the code itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked that TorchText has updated their usage as well:

https://github.com/pytorch/text/search?q=parse_csv

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just making sure we both fine in terms of releases and will not break someone.

@NivekT
Copy link
Contributor Author

NivekT commented Feb 15, 2022

@ejguan @VitalyFedyunin Let me know if there is any suggestion for the tutorial here.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/49/head branch February 20, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants