-
Notifications
You must be signed in to change notification settings - Fork 166
Adding TorchData tutorial #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D34144164](https://our.internmc.facebook.com/intern/diff/D34144164) [ghstack-poisoned]
Differential Revision: [D34144164](https://our.internmc.facebook.com/intern/diff/D34144164) [ghstack-poisoned]
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Adding a basic tutorial for TorchData Differential Revision: [D34144164](https://our.internmc.facebook.com/intern/diff/D34144164) [ghstack-poisoned]
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
||
```py | ||
@functional_datapipe("parse_csv_files") | ||
@functional_datapipe("parse_csv") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could break TorchText datasets, can you please verify with them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functional API was changed a long time ago, it is the README file that didn't get updated.
The change here updates the README file, not the code itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked that TorchText has updated their usage as well:
https://github.com/pytorch/text/search?q=parse_csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, just making sure we both fine in terms of releases and will not break someone.
@ejguan @VitalyFedyunin Let me know if there is any suggestion for the tutorial here. |
Stack from ghstack:
Adding a basic tutorial for TorchData
Differential Revision: D34144164