Skip to content

Require trove-classifiers>=2024.10.12 #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
radarhere wants to merge 1 commit into from
Closed

Require trove-classifiers>=2024.10.12 #8513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ jobs:
pytest
pytest-cov
pytest-timeout
trove-classifiers>=2024.10.12
Copy link
Member

@hugovk hugovk Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things are essentially the test dependencies, trove-classifiers>=2024.10.12 being required for a pyroma test.

Can we list this new trove-classifiers>=2024.10.12 in pyproject.toml's optional-dependencies.tests, remove this step (and duplicated dependencies), and modify the Build Pillow step below to pip install with the tests extra?

-        cmd /c "winbuild\build\build_env.cmd && $env:pythonLocation\python.exe -m pip install -v $FLAGS ."
+        cmd /c "winbuild\build\build_env.cmd && $env:pythonLocation\python.exe -m pip install -v $FLAGS .[tests]"


- name: Install CPython dependencies
if: "!contains(matrix.python-version, 'pypy')"
Expand Down
Loading