Skip to content

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Oct 29, 2024

main has started failing - https://github.com/python-pillow/Pillow/actions/runs/11573601676/job/32216060741#step:28:4035

   +         'Some of your classifiers are not standard classifiers:\n'
   +         'License :: OSI Approved :: CMU License (MIT-CMU)',

pytest
pytest-cov
pytest-timeout
trove-classifiers>=2024.10.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things are essentially the test dependencies, trove-classifiers>=2024.10.12 being required for a pyroma test.

Can we list this new trove-classifiers>=2024.10.12 in pyproject.toml's optional-dependencies.tests, remove this step (and duplicated dependencies), and modify the Build Pillow step below to pip install with the tests extra?

-        cmd /c "winbuild\build\build_env.cmd && $env:pythonLocation\python.exe -m pip install -v $FLAGS ."
+        cmd /c "winbuild\build\build_env.cmd && $env:pythonLocation\python.exe -m pip install -v $FLAGS .[tests]"

@radarhere
Copy link
Member Author

Actually, I cleared the cache, and it's working again - https://github.com/python-pillow/Pillow/actions/runs/11574569253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants